-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scroll to issue sidebar dropdowns #31597
Open
a1012112796
wants to merge
4
commits into
go-gitea:main
Choose a base branch
from
a1012112796:zzc/dev/issue_sidebar
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+120
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as title, fix go-gitea#31589 Signed-off-by: a1012112796 <[email protected]>
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Jul 9, 2024
pull-request-size
bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Jul 9, 2024
github-actions
bot
added
the
modifies/templates
This PR modifies the template files
label
Jul 9, 2024
Signed-off-by: a1012112796 <[email protected]>
6543
reviewed
Jul 10, 2024
techknowlogick
added
type/enhancement
An improvement of existing functionality
topic/ui
Change the appearance of the Gitea UI
labels
Jul 11, 2024
6543
approved these changes
Jul 11, 2024
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Jul 11, 2024
It's better to use Vue rather than Go template there if you would like to do a refactor. Because they should be refactored to an instance UI in the future. So we don't need to do it twice. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
modifies/templates
This PR modifies the template files
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
topic/ui
Change the appearance of the Gitea UI
type/enhancement
An improvement of existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title, fix #31589
examples: