Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scroll to issue sidebar dropdowns #31597

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

a1012112796
Copy link
Member

as title, fix #31589

examples:
屏幕截图 2024-07-09 110007

屏幕截图 2024-07-09 105146

屏幕截图 2024-07-09 102303

屏幕截图 2024-07-09 101441

屏幕截图 2024-07-09 100859

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 9, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 9, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Jul 9, 2024
Signed-off-by: a1012112796 <[email protected]>
@techknowlogick techknowlogick added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Jul 11, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 11, 2024
@lunny
Copy link
Member

lunny commented Aug 12, 2024

It's better to use Vue rather than Go template there if you would like to do a refactor. Because they should be refactored to an instance UI in the future. So we don't need to do it twice.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Oct 13, 2024

  1. It could only use tmpl at the moment, but not Vue
  2. Some changes don't seem proper. For example: why using no-select? It has other meanings in code, and shouldn't be used as a new purpose.
  3. I guess you mean const $menu = $(`${select_id} > .menu`), but not use more :not filters.

@wxiaoguang
Copy link
Contributor

  1. Be careful of conflicts with Support issue template assignees #31083 , do not lose changes from it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add scroll to dropdowns
6 participants