Skip to content

WIP: Fix incorrect init order#31031

Closed
wxiaoguang wants to merge 1 commit intogo-gitea:mainfrom
wxiaoguang:fix-init-order
Closed

WIP: Fix incorrect init order#31031
wxiaoguang wants to merge 1 commit intogo-gitea:mainfrom
wxiaoguang:fix-init-order

Conversation

@wxiaoguang
Copy link
Copy Markdown
Contributor

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 20, 2024
@wxiaoguang wxiaoguang marked this pull request as draft May 20, 2024 16:33
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label May 20, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 20, 2024
@wxiaoguang
Copy link
Copy Markdown
Contributor Author

Still WIP because the problem seems more complex than I thought. Maybe will try to figure out a better solution in 1.23

@wxiaoguang wxiaoguang added the pr/wip This PR is not ready for review label May 21, 2024
@wxiaoguang wxiaoguang changed the title Fix incorrect init order WIP: Fix incorrect init order May 21, 2024
@wxiaoguang wxiaoguang closed this Jul 17, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 15, 2024
@wxiaoguang
Copy link
Copy Markdown
Contributor Author

Finally, the related regressions came .....

And this time the fix is: Fix incorrect setting loading order #36735

@wxiaoguang wxiaoguang deleted the fix-init-order branch February 24, 2026 09:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/go Pull requests that update Go code pr/wip This PR is not ready for review type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants