Avoid importing modules/web/middleware in modules/session
#30584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfogre
added
type/enhancement
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
|
Although it's not a bugfix, I still hope to backport it to follow #30375. |
lunny
approved these changes
Apr 19, 2024
GiteaBot
added
lgtm/need 1
wxiaoguang
approved these changes
Apr 19, 2024
GiteaBot
added
lgtm/done
wolfogre
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 19, 2024
…ea#30584) Related to go-gitea#30375. It doesn't make sense to import `modules/web/middleware` and `modules/setting` in `modules/web/session` since the last one is more low-level. And it looks like a workaround to call `DeleteLegacySiteCookie` in `RegenerateSession`, so maybe we could reverse the importing by registering hook functions.
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 19, 2024
…ea#30584) Related to go-gitea#30375. It doesn't make sense to import `modules/web/middleware` and `modules/setting` in `modules/web/session` since the last one is more low-level. And it looks like a workaround to call `DeleteLegacySiteCookie` in `RegenerateSession`, so maybe we could reverse the importing by registering hook functions.
GiteaBot
removed
the
reviewed/wait-merge
wolfogre
added
the
skip-changelog
silverwind
pushed a commit
that referenced
this pull request
Apr 19, 2024
#30588) Backport #30584 by @wolfogre Related to #30375. It doesn't make sense to import `modules/web/middleware` and `modules/setting` in `modules/web/session` since the last one is more low-level. And it looks like a workaround to call `DeleteLegacySiteCookie` in `RegenerateSession`, so maybe we could reverse the importing by registering hook functions. Co-authored-by: Jason Song <[email protected]>
silverwind
pushed a commit
that referenced
this pull request
Apr 19, 2024
#30589) Backport #30584 by @wolfogre Related to #30375. It doesn't make sense to import `modules/web/middleware` and `modules/setting` in `modules/web/session` since the last one is more low-level. And it looks like a workaround to call `DeleteLegacySiteCookie` in `RegenerateSession`, so maybe we could reverse the importing by registering hook functions. Co-authored-by: Jason Song <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 19, 2024
* giteaofficial/main: Fix project description rendering for org (go-gitea#30587) Fix changelog (main) (go-gitea#30582) Avoid importing `modules/web/middleware` in `modules/session` (go-gitea#30584) Enable npm cache on `setup-node` action (go-gitea#30577)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #30375.
It doesn't make sense to import
modules/web/middlewareandmodules/settinginmodules/web/sessionsince the last one is more low-level.And it looks like a workaround to call
DeleteLegacySiteCookieinRegenerateSession, so maybe we could reverse the importing by registering hook functions.