Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid losing token when updating mirror settings (#30429) #30466

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Avoid losing token when updating mirror settings (#30429) #30466

merged 2 commits into from
Apr 15, 2024

Commits on Apr 14, 2024

  1. Avoid losing token when updating mirror settings (go-gitea#30429) 

    Fix go-gitea#30416.

Before (it shows as "Unset" while there's a token):

<img width="980" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/d7148e3e-62c9-4d2e-942d-3d795b79515a">

After:

<img width="977" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/24aaa1db-5baa-4204-9081-470b15ea72b5">

The username shows as "oauth2" because of
https://github.com/go-gitea/gitea/blob/f9fdac9809335729b2ac3227b2a5f71a62fc64ad/services/migrations/dump.go#L99

I have checked that all usage of `MirrorRemoteAddress` has been updated.

<img width="1806" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/2f042501-2824-4511-9203-c84a6731a02d">

However, it needs to be checked again when backporting.

---------

Co-authored-by: Giteabot <[email protected]>
    @wolfogre @GiteaBot @lunny
    2 people authored and lunny committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    abeb055 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Merge branch 'release/v1.21' into lunny/backport_30429

    @GiteaBot
    GiteaBot authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    d234eb7 View commit details
    Browse the repository at this point in the history