Limit the max line length when parsing git grep output #30418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
added
type/bug
backport/v1.22
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
wxiaoguang
force-pushed
the
fix-git-grep
branch
from
e9db656
to
2180467
Compare
delvh
approved these changes
Apr 11, 2024
Comment on lines
+86
to
+88
| if len(lineBytes) == 0 && err != nil { | ||
| break | ||
| } |
There was a problem hiding this comment.
Pity that we now have to treat err != nil as a successful case.
I mean, it does somewhat make sense, but at the same time it probably leads to false negative results.
There was a problem hiding this comment.
Good catch. Actually I have thought about this change and I think it should be good enough.
The real cases for returning "err" in this "grep" functions:
- Command fails, the error is returned by "cmd.Run"
- Pipe fails (this case), I think it would seldom happen in real life. Even if happens, returning partially parsed results is still better than showing a 500 error page.
GiteaBot
added
lgtm/need 1
a1012112796
approved these changes
Apr 12, 2024
GiteaBot
added
lgtm/done
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 12, 2024
wxiaoguang
added a commit
that referenced
this pull request
Apr 12, 2024
Backport #30418 by wxiaoguang Co-authored-by: wxiaoguang <[email protected]>
delvh
added
the
skip-changelog
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Apr 13, 2024
* origin/main: (1540 commits)
Add `interface{}` to `any` replacement to `make fmt`, exclude `*.pb.go` (go-gitea#30461)
Fix network error when open/close organization/individual projects and redirect to project page (go-gitea#30387)
Avoid losing token when updating mirror settings (go-gitea#30429)
Fix label rendering (go-gitea#30456)
Add comment for ContainsRedirectURI about the exact match (go-gitea#30457)
Update JS and PY deps, lock eslint and related plugins (go-gitea#30452)
Refactor cache and disable go-chi cache (go-gitea#30417)
Fix admin notice view-detail (go-gitea#30450)
Fix mirror error when mirror repo is empty (go-gitea#30432)
Add `/public/assets/img/webpack` to ignore files again (go-gitea#30451)
Lock a few tool dependencies to major versions (go-gitea#30439)
Fix commit status cache which missed target_url (go-gitea#30426)
Remove jQuery from the commit graph (except Fomantic) (go-gitea#30395)
Fix rename branch 500 when the target branch is deleted but exist in database (go-gitea#30430)
Limit the max line length when parsing git grep output (go-gitea#30418)
Change the default maxPerPage for gitbucket (go-gitea#30392)
Fix the spacing issue in the Project view (go-gitea#30415)
Add commit status summary table to reduce query from commit status table (go-gitea#30223)
Split `issue edit` code from `repo-legacy.js` into its own file (go-gitea#30419)
Check the token's owner and repository when registering a runner (go-gitea#30406)
...
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 14, 2024
* giteaofficial/main: Fix JS error when opening to expanded code comment (go-gitea#30463) fix: Fix to delete cookie when AppSubURL is non-empty (go-gitea#30375) Add `interface{}` to `any` replacement to `make fmt`, exclude `*.pb.go` (go-gitea#30461) Fix network error when open/close organization/individual projects and redirect to project page (go-gitea#30387) Avoid losing token when updating mirror settings (go-gitea#30429) Fix label rendering (go-gitea#30456) Add comment for ContainsRedirectURI about the exact match (go-gitea#30457) Update JS and PY deps, lock eslint and related plugins (go-gitea#30452) Refactor cache and disable go-chi cache (go-gitea#30417) Fix admin notice view-detail (go-gitea#30450) Fix mirror error when mirror repo is empty (go-gitea#30432) Add `/public/assets/img/webpack` to ignore files again (go-gitea#30451) Lock a few tool dependencies to major versions (go-gitea#30439) Fix commit status cache which missed target_url (go-gitea#30426) Remove jQuery from the commit graph (except Fomantic) (go-gitea#30395) Fix rename branch 500 when the target branch is deleted but exist in database (go-gitea#30430) Limit the max line length when parsing git grep output (go-gitea#30418)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.