Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix action runner offline label padding #29691

Merged
merged 4 commits into from
Mar 9, 2024
Merged

Fix action runner offline label padding #29691

merged 4 commits into from
Mar 9, 2024

Conversation

harryzcy
Copy link
Contributor

@harryzcy harryzcy commented Mar 9, 2024 •
edited
Loading

Before:

The offline padding is calc(.833em - 1px) from basic CSS class, but idle padding is 6px.

image

After:

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 9, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Mar 9, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 9, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 9, 2024
@silverwind silverwind enabled auto-merge (squash) March 9, 2024 12:12
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 9, 2024
@denyskon denyskon added topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality labels Mar 9, 2024
@denyskon denyskon added this to the 1.22.0 milestone Mar 9, 2024
@silverwind silverwind merged commit a192a5e into go-gitea:main Mar 9, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 9, 2024
@harryzcy harryzcy deleted the fix-offline-padding branch March 9, 2024 14:20
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 9, 2024
@zjjhot
Merge remote-tracking branch 'upstream/main'
4564fbd 
* upstream/main:
  Fix action runner offline label padding (go-gitea#29691)
  Update allowed attachment types (go-gitea#29688)
  Completely style the webkit autofill (go-gitea#29683)
  Include go files in tailwind processing (go-gitea#29686)
  Fix WebHookEditor regression from jQuery removal (go-gitea#29692)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@denyskon denyskon denyskon approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@harryzcy @silverwind @denyskon @delvh @GiteaBot