Fix URL calculation in clone input box #29470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
silverwind
added
backport/v1.21
Ported the function as-is and added comments so we don't forget about this in the future. Fixes: go-gitea#29462
wxiaoguang
approved these changes
Feb 28, 2024
GiteaBot
added
lgtm/need 1
|
I haven't looked at the frontend closely in a while, is there no way to reuse the same code instead of trying to keep them in sync? |
delvh
approved these changes
Feb 28, 2024
GiteaBot
added
lgtm/done
|
Well… there is one:
|
|
No easy way to share code between a inline scripts and scripts that build with webpack. Moving the inline script to webpack causes rendering flashes, only web components could avoid those while staying in webpack. |
|
Maybe https://github.com/icelam/html-inline-script-webpack-plugin can do it in the future. |
jolheiser
approved these changes
Feb 28, 2024
jolheiser
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Feb 28, 2024
Ported the function as-is and added comments so we don't forget about this in the future. Fixes: go-gitea#29462
GiteaBot
added
backport/done
jolheiser
pushed a commit
that referenced
this pull request
Feb 28, 2024
Backport #29470 by @silverwind Ported the function as-is and added comments so we don't forget about this in the future. Fixes: #29462 Co-authored-by: silverwind <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 29, 2024
* giteaofficial/main: (23 commits) Fix wrong test usage of `AppSubURL` (go-gitea#29459) Improve contrast on blame timestamp, fix double border (go-gitea#29482) Fix/Improve `processWindowErrorEvent` (go-gitea#29407) Apply compact padding to small buttons with svg icons (go-gitea#29471) Fix counter display number incorrectly displayed on the page (go-gitea#29448) Fix incorrect user location link on profile page (go-gitea#29474) Fix workflow trigger event bugs (go-gitea#29467) Fix URL calculation in clone input box (go-gitea#29470) Remove jQuery from the "find file" page (go-gitea#29456) Move generate from module to service (go-gitea#29465) The job should always run when `if` is `always()` (go-gitea#29464) Recolor dark theme to blue shade (go-gitea#29283) Let ctx.FormOptionalBool() return optional.Option[bool] (go-gitea#29461) Implement actions badge svgs (go-gitea#28102) Fix missed return (go-gitea#29450) Use tailwind instead of `gt-[wh]-` helper classes (go-gitea#29423) Lock issues and pulls faster (go-gitea#29436) Allow to change primary email before account activation (go-gitea#29412) Update docs about `DEFAULT_ACTIONS_URL` (go-gitea#29442) Only use supported sort order for "explore/users" page (go-gitea#29430) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported the function as-is and added comments so we don't forget about this in the future.
Fixes: #29462