Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advertise WebAuthn support #29176

Merged
merged 8 commits into from
Feb 15, 2024
Merged

Advertise WebAuthn support #29176

merged 8 commits into from
Feb 15, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Feb 15, 2024 •
edited
Loading

@6543 6543 added type/feature Completely new functionality. Can only be merged if feature freeze is not active. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! labels Feb 15, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 15, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 15, 2024
KN4CK3R
KN4CK3R requested changes Feb 15, 2024
View reviewed changes
Copy link
Member

@KN4CK3R KN4CK3R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using AppURL with AppSubURL is wrong.

routers/web/passkey.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 15, 2024
delvh
delvh reviewed Feb 15, 2024
View reviewed changes
routers/web/passkey.go Outdated Show resolved Hide resolved
routers/web/passkey.go Outdated Show resolved Hide resolved
routers/web/passkey.go Outdated Show resolved Hide resolved
6543
6543 commented Feb 15, 2024
View reviewed changes
routers/web/passkey.go Outdated Show resolved Hide resolved
6543
6543 commented Feb 15, 2024
View reviewed changes
routers/web/passkey.go Outdated Show resolved Hide resolved
@6543 6543 requested a review from KN4CK3R February 15, 2024 13:27
@delvh delvh changed the title Advertice WebauthN support Advertise WebAuthn support Feb 15, 2024
@6543 6543 added this to the 1.22.0 milestone Feb 15, 2024
@6543
Copy link
Member Author

6543 commented Feb 15, 2024 •
edited
Loading

added to current milestone as code is simple and regressions are unlikely + it adds an security feature

KN4CK3R
KN4CK3R approved these changes Feb 15, 2024
View reviewed changes
routers/web/passkey.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Feb 15, 2024
@6543 6543 enabled auto-merge (squash) February 15, 2024 17:21
6543
6543 commented Feb 15, 2024
View reviewed changes
routers/web/passkey.go Outdated Show resolved Hide resolved
@6543 6543 merged commit 702a876 into go-gitea:main Feb 15, 2024
26 checks passed
@6543 6543 deleted the advertice-webauthn-support branch February 15, 2024 18:33
@wxiaoguang wxiaoguang added the backport/v1.21 This PR should be backported to Gitea 1.21 label Feb 16, 2024
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.21. @6543, please send one manually. 🍵

go run ./contrib/backport 29176
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Feb 16, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 16, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
1688a0c 
* giteaofficial/main: (23 commits)
  Remove jQuery from SSH key form parser (go-gitea#29193)
  Refactor request function (go-gitea#29187)
  Docker Tag Information in Docs (go-gitea#29047)
  Fix gitea-action user avatar broken on edited menu (go-gitea#29190)
  Disable parallel Make execution (go-gitea#29186)
  Auto-update the system status in admin dashboard (go-gitea#29163)
  Avoid vue warning in dev mode (go-gitea#29188)
  Update JS and PY dependencies (go-gitea#29184)
  [skip ci] Updated translations via Crowdin
  Implement contributors graph (go-gitea#27882)
  Add support for action artifact serve direct (go-gitea#29120)
  Advertise WebAuthn support (go-gitea#29176)
  Tweak repo header (go-gitea#29134)
  Change webhook-type in create-view (go-gitea#29114)
  Remove jQuery from the comment task list (go-gitea#29170)
  Fix can not select team reviewers when reviewers is empty (go-gitea#29174)
  move sign in labels to be above inputs (go-gitea#28753)
  Refactor locale&string&template related code (go-gitea#29165)
  Extract linguist code to method (go-gitea#29168)
  bump to use go 1.22 (go-gitea#29119)
  ...
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@6543 @silverwind
Advertise WebAuthn support (go-gitea#29176)
377b1d9 
This well-known indicates for password manager, that passkeys are supported.

source:
https://android-developers.googleblog.com/2023/10/make-passkey-endpoints-well-known-url-part-of-your-passkey-implementation.html

spec:
https://github.com/ms-id-standards/MSIdentityStandardsExplainers/blob/main/PasskeyEndpointsWellKnownUrl/explainer.md
@wxiaoguang wxiaoguang added backport/done All backports for this PR have been created and removed backport/done All backports for this PR have been created labels Feb 21, 2024
@6543 6543 removed the backport/v1.21 This PR should be backported to Gitea 1.21 label Feb 22, 2024
@6543
Copy link
Member Author

6543 commented Feb 22, 2024

I would not backport that feature ...

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

Assignees
No one assigned
Labels
backport/manual No power to the bots! Create your backport yourself! lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @GiteaBot @KN4CK3R @delvh @wxiaoguang