Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop "@" from email sender to avoid spam filters #29109

Merged
merged 4 commits into from
Feb 10, 2024

Commits on Feb 9, 2024

  1. Drop "@" from email sender to avoid spam filters

    Commit 360b3fd (Include username in email headers (go-gitea#28981),
    2024-02-03) adds usernames to the From field of notification emails in
    the form of `Display Name (@username)`, to prevent spoofing. However,
    some email filtering software flags "@" in the display name part of the
    From field as potential spoofing, as you could set the display name part
    to another email address than the one you are sending from (e.g.
    `From: "apparent@email-address" <actual@email-address>`). To avoid
    being flagged, instead send emails from `Display Name (username)`.
    
    Closes: go-gitea#29107
    gwymor committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    f110138 View commit details
    Browse the repository at this point in the history
  2. Fix linter error

    "the argument is already a string, there's no need to use fmt.Sprintf
    (gosimple)"
    gwymor committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    bad0061 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b1cae90 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2024

  1. Configuration menu
    Copy the full SHA
    d431da9 View commit details
    Browse the repository at this point in the history