Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct has error check for internal responses #28796

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Use correct has error check for internal responses #28796

merged 2 commits into from
Jan 15, 2024

Conversation

wxiaoguang
Copy link
Contributor

resp != nil doesn't mean the request really succeeded. Add a comment for requestJSONResp to clarify the behavior.

@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 15, 2024
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Jan 15, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 15, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 15, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 15, 2024
@yp05327
Copy link
Contributor

yp05327 commented Jan 15, 2024 •
edited
Loading

Is it possible to return requestJSONResp directly? As extra.HasError() will be checked outside of these funcstions. 🤔

@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Jan 15, 2024 •
edited
Loading

Is it possible to return requestJSONResp directly? As extra.HasError() will be checked outside of these funcstions. 🤔

Feel free to do so if it makes code more readable and maintainable.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 15, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 15, 2024
@lunny lunny enabled auto-merge (squash) January 15, 2024 10:51
@yardenshoham yardenshoham added the backport/v1.21 This PR should be backported to Gitea 1.21 label Jan 15, 2024
@delvh delvh changed the title Caller should check the ResponseExtra.HasError() first to see whether the request fails Use correct has error check for internal responses Jan 15, 2024
@lunny lunny merged commit b0e6c25 into go-gitea:main Jan 15, 2024
25 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jan 15, 2024
@wxiaoguang @GiteaBot
Caller should check the ResponseExtra.HasError() first to see whether…
3fbad41 
… the request fails (go-gitea#28796)

`resp != nil` doesn't mean the request really succeeded. Add a comment
for requestJSONResp to clarify the behavior.
@GiteaBot GiteaBot mentioned this pull request Jan 15, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Jan 15, 2024
@wxiaoguang wxiaoguang deleted the fix-cli-response branch January 15, 2024 11:17
KN4CK3R pushed a commit that referenced this pull request Jan 15, 2024
@GiteaBot @wxiaoguang
Use correct has error check for internal responses (#28796) (#28798)
cbf3666 
Backport #28796 by @wxiaoguang

`resp != nil` doesn't mean the request really succeeded. Add a comment
for requestJSONResp to clarify the behavior.

Co-authored-by: wxiaoguang <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 16, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
b112684 
* giteaofficial/main: (34 commits)
  Use refname:strip-2 instead of refname:short when syncing tags (go-gitea#28797)
  Add gist to comparison (go-gitea#28809)
  Fix links in issue card (go-gitea#28806)
  Show latest commit for file (go-gitea#28067)
  Add ability to see open and closed issues at the same time (go-gitea#28757)
  Display latest sync time for pull mirrors on the repo page (go-gitea#28712)
  Fix `GetCommitStatuses` (go-gitea#28787)
  Caller should check the ResponseExtra.HasError() first to see whether the request fails (go-gitea#28796)
  Rework markup link rendering (go-gitea#26745)
  Fix nil pointer panic when exec some gitea cli command (go-gitea#28791)
  Add branch protection setting for ignoring stale approvals (go-gitea#28498)
  Forbid removing the last admin user (go-gitea#28337)
  Fix when private user following user, private user will not be counted in his own view (go-gitea#28037)
  Update github.com/cloudflare/circl (go-gitea#28789)
  Move more functions to db.Find (go-gitea#28419)
  Add non-JS fallback for reaction tooltips (go-gitea#28785)
  Modernize merge button (go-gitea#28140)
  Warn that `DISABLE_QUERY_AUTH_TOKEN` is false only if it's explicitly defined (go-gitea#28783)
  Speed up loading the dashboard on mysql/mariadb (go-gitea#28546)
  Fix schedule tasks bugs (go-gitea#28691)
  ...
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@wxiaoguang @fuxiaohei
Caller should check the ResponseExtra.HasError() first to see whether…
ad1bcca 
… the request fails (go-gitea#28796)

`resp != nil` doesn't mean the request really succeeded. Add a comment
for requestJSONResp to clarify the behavior.
@yp05327 yp05327 mentioned this pull request Jan 18, 2024
Merged
lunny pushed a commit that referenced this pull request Jan 19, 2024
@yp05327
Return responseText instead of string in some functions (#28836)
b60a7c3 
Follow
#28796 (comment)
henrygoodman pushed a commit to henrygoodman/gitea that referenced this pull request Jan 31, 2024
@wxiaoguang @henrygoodman
Caller should check the ResponseExtra.HasError() first to see whether…
69ab7b9 
… the request fails (go-gitea#28796)

`resp != nil` doesn't mean the request really succeeded. Add a comment
for requestJSONResp to clarify the behavior.
henrygoodman pushed a commit to henrygoodman/gitea that referenced this pull request Jan 31, 2024
@yp05327 @henrygoodman
Return responseText instead of string in some functions (go-gitea#2…
34cb11f 
…8836)

Follow
go-gitea#28796 (comment)
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@wxiaoguang @silverwind
Caller should check the ResponseExtra.HasError() first to see whether…
8c59caa 
… the request fails (go-gitea#28796)

`resp != nil` doesn't mean the request really succeeded. Add a comment
for requestJSONResp to clarify the behavior.
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@yp05327 @silverwind
Return responseText instead of string in some functions (go-gitea#2…
66870e2 
…8836)

Follow
go-gitea#28796 (comment)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@yardenshoham yardenshoham yardenshoham approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
6 participants
@wxiaoguang @yp05327 @lunny @yardenshoham @delvh @GiteaBot