Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set language in admin user view #28449

Merged
merged 17 commits into from
Mar 2, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Dec 13, 2023

image
/admin/users/<UserID>/edit

image
/admin/users/<UserID>


Sponsored by Kithara Software GmbH

@6543 6543 added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Dec 13, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 13, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 13, 2023
@lunny
Copy link
Member

lunny commented Dec 13, 2023

I don't think the title is related with the content.

@6543
Copy link
Member Author

6543 commented Dec 13, 2023

uh sorry i guess i git the wrong title :D

(branch was bit misleading named as i played with the former title topic before )

@6543 6543 changed the title Admin user view sort by mail Add option to set languange in admin user view Dec 13, 2023
@lunny
Copy link
Member

lunny commented Dec 13, 2023

Why users don't change the language themselves but need admin to help? I can't imagine the scenes

@delvh delvh changed the title Add option to set languange in admin user view Add option to set language in admin user view Dec 13, 2023
@delvh
Copy link
Member

delvh commented Dec 13, 2023

Yeah, same as @lunny.
The usecase isn't clear to me either.
Instead, it sounds like something that can be abused when some admin suddenly switches your Gitea language to arabic as a prank

@6543
Copy link
Member Author

6543 commented Dec 13, 2023

@lunny @delvh if an admin does such a "joke" you should not consider to use that instance at all !!!

and yes if you are not a self-registration instance, but you get an account created by the instance admins, it's possible that you have to set the language.

for now this is done by log in as the user after it has been created and then change the language.
but you loose the feature to let the user be forced to have to set a new password.

@6543
Copy link
Member Author

6543 commented Dec 13, 2023

And not all people speak English, to be honest...

@6543 6543 added this to the 1.22.0 milestone Dec 18, 2023
services/forms/admin.go Show resolved Hide resolved
templates/admin/user/edit.tmpl Show resolved Hide resolved
@6543 6543 requested a review from delvh December 19, 2023 16:47
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 30, 2023
@6543 6543 requested a review from KN4CK3R February 20, 2024 15:16
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 2, 2024
@denyskon denyskon added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 2, 2024
@delvh
Copy link
Member

delvh commented Mar 2, 2024

@6543 please update the branch

@delvh delvh added the reviewed/prioritize-merge PR is in the merge queue. Merge as soon as possible, i.e. as edits by maintainers are not enabled label Mar 2, 2024
@6543 6543 merged commit e3e6569 into go-gitea:main Mar 2, 2024
24 of 25 checks passed
@6543 6543 deleted the admin-user-view_sort-by-mail branch March 2, 2024 21:55
@GiteaBot GiteaBot removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. reviewed/prioritize-merge PR is in the merge queue. Merge as soon as possible, i.e. as edits by maintainers are not enabled labels Mar 2, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 3, 2024
* upstream/main:
  Breaking summary for template refactoring (go-gitea#29395)
  [skip ci] Updated translations via Crowdin
  Fix incorrect cookie path for AppSubURL (go-gitea#29534)
  gitea.service: Remove syslog.target (go-gitea#29550)
  Add option to set language in admin user view (go-gitea#28449)
  Fix elipsis button not working if the last commit loading is deferred (go-gitea#29544)
  Fix incorrect relative/absolute URL usages (go-gitea#29531)
  Add support for API blob upload of release attachments (go-gitea#29507)
  Fix queue worker incorrectly stopped when there are still more items in the queue (go-gitea#29532)
  remove util.OptionalBool and related functions (go-gitea#29513)
  Rename Action.GetDisplayName to GetActDisplayName (go-gitea#29540)
  Make PR form use toast to show error message (go-gitea#29545)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants