-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing exclusive in advanced label options #28322
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Dec 2, 2023
pull-request-size
bot
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Dec 2, 2023
Kind/* should not be exclusive but I agree on moving breaking to different category |
May non-exclusive labels also be displayed with scoped colour boxes as exclusive ones? |
Yes, I would like that also, there is issue for this #23665 |
@LucaZulberti Could you adapt your PR to only move breaking label? The label style change can then be addressed in another PR |
denyskon
added
issue/needs-feedback
For bugs, we need more details. For features, the feature must be described in more detail
type/enhancement
An improvement of existing functionality
topic/issues
labels
Jan 20, 2024
pull-request-size
bot
added
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
and removed
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Jan 20, 2024
Done ;-) |
denyskon
approved these changes
Jan 20, 2024
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Jan 20, 2024
denyskon
added
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
issue/needs-feedback
For bugs, we need more details. For features, the feature must be described in more detail
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Jan 20, 2024
lunny
approved these changes
Jan 20, 2024
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Jan 20, 2024
lunny
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Jan 22, 2024
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Jan 22, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 23, 2024
* upstream/main: Fix sort bug on repository issues list (go-gitea#28897) Upgrade xorm to v1.3.7 to fix a resource leak problem caused by Iterate (go-gitea#28891) Add missing exclusive in advanced label options (go-gitea#28322) Fix `DeleteCollaboration` transaction behaviour (go-gitea#28886) Fix schedule not trigger bug because matching full ref name with short ref name (go-gitea#28874)
henrygoodman
pushed a commit
to henrygoodman/gitea
that referenced
this pull request
Jan 31, 2024
Hi, I think these changes could be useful for default labels when creating new repos. The PR includes the following changes: - Add missing exclusive flag for Kind/ scope in labels. - Move Breaking label into new Compat/ scope.
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
Hi, I think these changes could be useful for default labels when creating new repos. The PR includes the following changes: - Add missing exclusive flag for Kind/ scope in labels. - Move Breaking label into new Compat/ scope.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
topic/issues
type/enhancement
An improvement of existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I think these changes could be useful for default labels when creating new repos.
The PR includes the following changes: