Calculate package size quota using package creator ID instead of owner ID (#28007)#28030
Closed
GiteaBot wants to merge 1 commit intogo-gitea:release/v1.21from
Closed
Calculate package size quota using package creator ID instead of owner ID (#28007)#28030GiteaBot wants to merge 1 commit intogo-gitea:release/v1.21from
GiteaBot wants to merge 1 commit intogo-gitea:release/v1.21from
Conversation
…ad of owner ID (go-gitea#28007) Changed behavior to calculate package quota limit using package `creator ID` instead of `owner ID`. Currently, users are allowed to create an unlimited number of organizations, each of which has its own package limit quota, resulting in the ability for users to have unlimited package space in different organization scopes. This fix will calculate package quota based on `package version creator ID` instead of `package version owner ID` (which might be organization), so that users are not allowed to take more space than configured package settings. Also, there is a side case in which users can publish packages to a specific package version, initially published by different user, taking that user package size quota. Version in fix should be better because the total amount of space is limited to the quota for users sharing the same organization scope.
GiteaBot
added
topic/packages
type/enhancement
GiteaBot
added
the
lgtm/need 2
6543
changed the title
6543
approved these changes
Nov 13, 2023
GiteaBot
added
lgtm/need 1
GiteaBot
added
lgtm/blocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #28007 by @d1nch8g
Changed behavior to calculate package quota limit using package
creator IDinstead ofowner ID.Currently, users are allowed to create an unlimited number of organizations, each of which has its own package limit quota, resulting in the ability for users to have unlimited package space in different organization scopes. This fix will calculate package quota based on
package version creator IDinstead ofpackage version owner ID(which might be organization), so that users are not allowed to take more space than configured package settings.Also, there is a side case in which users can publish packages to a specific package version, initially published by different user, taking that user package size quota. Version in fix should be better because the total amount of space is limited to the quota for users sharing the same organization scope.