Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport to 1.2: Fix sending mail with a non-latin display name #2783

Merged
merged 1 commit into from
Oct 26, 2017
Merged

Backport to 1.2: Fix sending mail with a non-latin display name #2783

merged 1 commit into from
Oct 26, 2017

Conversation

ptman
Copy link
Contributor

@ptman ptman commented Oct 26, 2017

@rems4e @ptman
Fix sending mail with a non-latin display name. #2102 (#2559)
4fbdc12 
* Fix sending mail with a non-latin display name. #2102

Signed-off-by: Rémi Saurel <[email protected]>

* Take into account the possibility that setting.MailService.From is in `name <email@address>` format. #2102

Signed-off-by: Rémi Saurel <[email protected]>
@lafriks lafriks added this to the 1.2.2 milestone Oct 26, 2017
@lafriks
Copy link
Member

lafriks commented Oct 26, 2017

Can you force push to trigger drone again?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 26, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 26, 2017
@appleboy
Copy link
Member

@lafriks I trigger rebuild process manually.

@lafriks
Copy link
Member

lafriks commented Oct 26, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 26, 2017
@lafriks lafriks merged commit 33e1641 into go-gitea:release/v1.2 Oct 26, 2017
@ptman ptman deleted the fix-email branch October 26, 2017 07:57
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.2.2
Development

Successfully merging this pull request may close these issues.
5 participants
@ptman @lafriks @appleboy @tboerger @rems4e