-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid run change title process when the title is same #27467
Merged
techknowlogick
merged 2 commits into
go-gitea:main
from
yp05327:add-check-target-issue-title
Oct 6, 2023
Merged
Avoid run change title process when the title is same #27467
techknowlogick
merged 2 commits into
go-gitea:main
from
yp05327:add-check-target-issue-title
Oct 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Oct 6, 2023
pull-request-size
bot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
Oct 6, 2023
yp05327
changed the title
Avoid change title when the target title is as same as the old title
Avoid run change title process when the target title is as same as the old title
Oct 6, 2023
yp05327
changed the title
Avoid run change title process when the target title is as same as the old title
Avoid run change title process when the title is same
Oct 6, 2023
silverwind
approved these changes
Oct 6, 2023
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Oct 6, 2023
delvh
approved these changes
Oct 6, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Oct 6, 2023
delvh
added
backport/v1.20
This PR should be backported to Gitea 1.20
type/enhancement
An improvement of existing functionality
topic/ui-interaction
Change the process how users use Gitea instead of the visual appearance
labels
Oct 6, 2023
techknowlogick
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Oct 6, 2023
I was unable to create a backport for 1.20. @yp05327, please send one manually. 🍵
|
GiteaBot
added
backport/manual
No power to the bots! Create your backport yourself!
and removed
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
labels
Oct 6, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 8, 2023
* giteaoffical/main: (79 commits) Pre-register OAuth application for tea (go-gitea#27509) Fix mermaid flowchart margin issue (go-gitea#27503) add a shortcut to user's profile page to admin user details (go-gitea#27299) Fix actionlint (go-gitea#27513) [skip ci] Updated translations via Crowdin Update JS and PY dependencies (go-gitea#27501) Improve feed icons and feed merge text color (go-gitea#27498) Downgrade `go-co-op/gocron` to v1.31.1 (go-gitea#27511) Enable markdownlint `no-duplicate-header` (go-gitea#27500) bump go-deps (go-gitea#27489) Apply to became a maintainer (go-gitea#27491) change runner for binary [skip ci] Updated translations via Crowdin Remove .exe suffix when cross-compiling on Windows (go-gitea#27448) move re-useable workflow add checkout to disk-clean use hosted runners for nightly actions (go-gitea#27485) Avoid run change title process when the title is same (go-gitea#27467) Fix panic in storageHandler (go-gitea#27446) Rename the default themes to gitea-light, gitea-dark, gitea-auto (go-gitea#27419) ...
This was referenced Oct 10, 2023
silverwind
pushed a commit
that referenced
this pull request
Oct 10, 2023
silverwind
pushed a commit
that referenced
this pull request
Oct 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
backport/manual
No power to the bots! Create your backport yourself!
backport/v1.20
This PR should be backported to Gitea 1.20
backport/v1.21
This PR should be backported to Gitea 1.21
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
topic/ui-interaction
Change the process how users use Gitea instead of the visual appearance
type/enhancement
An improvement of existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user only changed the target branch or just did nothing and clicked the
Save
button, you will see the change log as following:This makes no sense, so we should check whether the title is surely changed before run the
ChangeTitle
.