Require MySQL 8.0, PostgreSQL 12, MSSQL 2012 #27337

silverwind · 2023-09-28T18:01:25Z

MySQL 5.7 support and testing is dropped
MySQL tests now execute against 8.1, up from 5.7 and 8.0
PostgreSQL 10 and 11 support ist dropped
PostgreSQL tests now execute against 16, up from 15
MSSQL 2008 support is dropped
MSSQL tests now run against locked 2022 version

Ref: https://endoflife.date/mysql
Ref: https://endoflife.date/postgresql
Ref: https://endoflife.date/mssqlserver

⚠️ BREAKING ⚠️

Support for MySQL 5.7, PostgreSQL 10 and 11, and MSSQL 2008 is dropped. You are encouraged to upgrade to supported versions.

- MySQL 5.7 support and testing is dropped - MySQL tests now only test against 8.1, previously it was 5.7 and 8.0 Fixes: go-gitea#25657

silverwind · 2023-09-28T18:07:26Z

Before merging this, we need to adjust the required checks config on github ui to update from test-mysql5 and test-mysql8 to just test-mysql.

delvh · 2023-09-28T19:25:59Z

I mean, we could also be so nice and block this PR until the mentioned versions are actually EOL.
But I'm also fine with the current approach.

denyskon · 2023-09-28T19:31:07Z

I don't think that people who use MySQL 5.7 also use Gitea nightly in production 😆
I think it's fine, the release will definitely happen after all of the mentioned versions are EOL.

silverwind · 2023-09-28T19:31:17Z

By the time the 1.22 branch releases they will be EOL. I imagine anyone running unstable builds will likely not run unsupported databases :)

denyskon · 2023-09-28T19:32:27Z

@silverwind ✨ same though at the same moment ✨

delvh · 2023-09-28T19:32:43Z

I don't think that people who use MySQL 5.7 also use Gitea nightly in production 😆

Good point.

Makefile

.github/workflows/pull-db-tests.yml

techknowlogick · 2023-09-28T20:49:31Z

Thanks for keeping this current 😀

Could you add a note that should someone need support for an outdated database that they can contact us for an "extended support contract" (or some other name?). As then we can then test for those older databases and add fixes into this codebase too. I know there are some people who are using the outdated mssql version that are paying MS for them to backport fixes, so they may need to have that support in Gitea too.

silverwind · 2023-09-28T20:56:16Z

Feel free to edit the OP to your liking :)

wxiaoguang · 2023-09-29T13:44:34Z

.github/workflows/pull-db-tests.yml

@@ -86,7 +86,7 @@ jobs:
    runs-on: ubuntu-latest
    services:
      mysql:
-        image: mysql:5.7
+        image: mysql:8.1


It should test with MySQL 8.0 but not 8.1

The same to pgsql/mssql

Why not test with latest? New deployments are likely to use latest. I see no point testing non-latest if we only test one version.

This one step I guess we could move to 8.0 because 8.1 is tested below separately, but I don't see much of a point either.

What if you used a MySQL 8.1 only syntax?

By your notion, we would have to test every single supported db version, which given our CI resources is likely not feasible. Also, MariaDB is completely untested.

Ideally, MariaDB should have a separate test.

For others, databases have pretty good backward compatibility. If MySQL 8.0 passes, then MySQL 8.1 are almost sure to pass.

Maybe we should stick to MySQL LTS versions? According to this 8.0, 8.4, 9.7 will be LTS:

No, at the moment, only the minimal supported version is enough.

I still don't understand the reasons. We can:

Test latest, be most likely correct for new deployment, but old ones may break with incompatibly SQL syntax etc.

Test oldest, be correct for ancient deployments, but unknown for new ones.

Test something in between, but by what rules?

I think it's easier to maintain if we just test latest, so that the maintainer updating this doesn't have to thing about obscure rules about which version to test.

Ideally we'd have a matrix build to easily add/remove versions. Currently it's a pain because of all the Makefile changes and such. If we had a matrix, I guess testing oldest and newest of each version would be ideal.

Test latest, be most likely correct for new deployment, but old ones may break with incompatibly SQL syntax etc.

No, it would break the old database easily.

Test oldest, be correct for ancient deployments, but unknown for new ones.

This is the right approach. It won't be "unknown": see my comment: databases have pretty good backward compatibility. If MySQL 8.0 passes, then MySQL 8.1 are almost sure to pass.

Test something in between, but by what rules?

No, it's not worth to be considered.

This PR doesn't change the behaviour of what we are doing with tests (w/ psql we're using latest, and w/ mqsl we were using 8.x).

I agree we should test both min/max db versions, but that can be done in a different PR.

lunny · 2023-09-30T09:09:04Z

Yes, if we say it required mysql 8.0, we should test the minial version 8.0 but not 8.1 like we did with Golang.

docs/content/installation/database-preparation.en-us.md

wxiaoguang · 2023-10-04T01:40:14Z

@techknowlogick

This PR doesn't change the behaviour of what we are doing with tests (w/ psql we're using latest, and w/ mqsl we were using 8.x).
I agree we should test both min/max db versions, but that can be done in a different PR.

Testing the minimal version is good enough and the right approach, like before.

But I guess nobody would really follow it if this gets merged, until some bugs like #22809 occurs (pgsql 10 works but pgsql 9 doesn't -- newer version works, older version fails)

This is my last comment for this problem, because I have explained enough and I do not want to bother people.

lunny · 2023-11-01T06:18:06Z

ref: #27429

Require MySQL >= 8.0, test with 8.1

6c33aa9

- MySQL 5.7 support and testing is dropped - MySQL tests now only test against 8.1, previously it was 5.7 and 8.0 Fixes: go-gitea#25657

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 28, 2023

pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 28, 2023

github-actions bot added type/docs This PR mainly updates/creates documentation topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile labels Sep 28, 2023

silverwind added pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! and removed type/docs This PR mainly updates/creates documentation topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile labels Sep 28, 2023

silverwind changed the title ~~Require MySQL >= 8.0, test with 8.1~~ Require MySQL 8.0 or greater, test with 8.1 Sep 28, 2023

add back services from previous mysql5 step

81aacf1

github-actions bot added type/docs This PR mainly updates/creates documentation topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile labels Sep 28, 2023

silverwind added 4 commits September 28, 2023 20:35

fix indent

520a5d5

more reverts

f026f4a

more reverts

3e18771

handle postgres and mysql

4d2c16b

silverwind changed the title ~~Require MySQL 8.0 or greater, test with 8.1~~ Require MySQL 8.0, Postgres 12, MSSQL 2012 Sep 28, 2023

delvh approved these changes Sep 28, 2023

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 28, 2023

denyskon approved these changes Sep 28, 2023

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 28, 2023

silverwind changed the title ~~Require MySQL 8.0, Postgres 12, MSSQL 2012~~ Require MySQL 8.0, PostgreSQL 12, MSSQL 2012 Sep 28, 2023

silverwind commented Sep 28, 2023

View reviewed changes

Makefile Show resolved Hide resolved

silverwind commented Sep 28, 2023

View reviewed changes

.github/workflows/pull-db-tests.yml Outdated Show resolved Hide resolved

Try with testgitea name to match Makefile

a197dd3

silverwind added 2 commits September 29, 2023 14:00

Merge branch 'main' into mysql8

c507648

Merge branch 'main' into mysql8

8a37770

wxiaoguang reviewed Sep 29, 2023

View reviewed changes

techknowlogick reviewed Oct 2, 2023

View reviewed changes

docs/content/installation/database-preparation.en-us.md Show resolved Hide resolved

techknowlogick and others added 2 commits October 1, 2023 23:05

Update docs/content/installation/database-preparation.en-us.md

77611ee

Merge branch 'main' into mysql8

2816901

techknowlogick merged commit e94f9fc into go-gitea:main Oct 3, 2023
25 checks passed

GiteaBot added this to the 1.22.0 milestone Oct 3, 2023

silverwind deleted the mysql8 branch October 3, 2023 20:51

GiteaBot added the kind/breaking label Oct 7, 2023

delvh removed the kind/breaking label Oct 7, 2023

GiteaBot added the kind/breaking label Oct 7, 2023

wxiaoguang mentioned this pull request Nov 28, 2023

Database migration fails when attempting to upgrade from version 1.20.5 #28247

Closed

go-gitea locked as resolved and limited conversation to collaborators Jan 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Require MySQL 8.0, PostgreSQL 12, MSSQL 2012 #27337

Require MySQL 8.0, PostgreSQL 12, MSSQL 2012 #27337

silverwind commented Sep 28, 2023 •

edited

Loading

silverwind commented Sep 28, 2023 •

edited

Loading

delvh commented Sep 28, 2023

denyskon commented Sep 28, 2023

silverwind commented Sep 28, 2023

denyskon commented Sep 28, 2023

delvh commented Sep 28, 2023

techknowlogick commented Sep 28, 2023

silverwind commented Sep 28, 2023

wxiaoguang Sep 29, 2023

silverwind Sep 29, 2023 •

edited

Loading

silverwind Sep 29, 2023 •

edited

Loading

wxiaoguang Sep 29, 2023

silverwind Sep 29, 2023 •

edited

Loading

wxiaoguang Sep 29, 2023

wxiaoguang Sep 29, 2023

silverwind Sep 29, 2023 •

edited

Loading

wxiaoguang Sep 30, 2023

techknowlogick Oct 3, 2023

lunny commented Sep 30, 2023

wxiaoguang commented Oct 4, 2023

lunny commented Nov 1, 2023

Require MySQL 8.0, PostgreSQL 12, MSSQL 2012 #27337

Require MySQL 8.0, PostgreSQL 12, MSSQL 2012 #27337

Conversation

silverwind commented Sep 28, 2023 • edited Loading

⚠️ BREAKING ⚠️

silverwind commented Sep 28, 2023 • edited Loading

delvh commented Sep 28, 2023

denyskon commented Sep 28, 2023

silverwind commented Sep 28, 2023

denyskon commented Sep 28, 2023

delvh commented Sep 28, 2023

techknowlogick commented Sep 28, 2023

silverwind commented Sep 28, 2023

wxiaoguang Sep 29, 2023

Choose a reason for hiding this comment

silverwind Sep 29, 2023 • edited Loading

Choose a reason for hiding this comment

silverwind Sep 29, 2023 • edited Loading

Choose a reason for hiding this comment

wxiaoguang Sep 29, 2023

Choose a reason for hiding this comment

silverwind Sep 29, 2023 • edited Loading

Choose a reason for hiding this comment

wxiaoguang Sep 29, 2023

Choose a reason for hiding this comment

wxiaoguang Sep 29, 2023

Choose a reason for hiding this comment

silverwind Sep 29, 2023 • edited Loading

Choose a reason for hiding this comment

wxiaoguang Sep 30, 2023

Choose a reason for hiding this comment

techknowlogick Oct 3, 2023

Choose a reason for hiding this comment

lunny commented Sep 30, 2023

wxiaoguang commented Oct 4, 2023

lunny commented Nov 1, 2023

silverwind commented Sep 28, 2023 •

edited

Loading

silverwind commented Sep 28, 2023 •

edited

Loading

silverwind Sep 29, 2023 •

edited

Loading

silverwind Sep 29, 2023 •

edited

Loading

silverwind Sep 29, 2023 •

edited

Loading

silverwind Sep 29, 2023 •

edited

Loading