Skip to content

Disable download action logs button when there's no logs #26114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KN4CK3R merged 6 commits into from
Jul 26, 2023
Merged

Disable download action logs button when there's no logs #26114

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
987680e
improve
yp05327 Jul 25, 2023
c62eeb3
improve
yp05327 Jul 26, 2023
87785d8
Merge branch 'main' into improve-download-logs-button
GiteaBot Jul 26, 2023
e19f458
Merge branch 'main' into improve-download-logs-button
GiteaBot Jul 26, 2023
b8546b5
Merge branch 'main' into improve-download-logs-button
GiteaBot Jul 26, 2023
43877bf
Merge branch 'main' into improve-download-logs-button
GiteaBot Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion web_src/js/components/RepoActionView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,11 @@
<SvgIcon name="octicon-gear" :size="18"/>
</button>
<div class="menu transition action-job-menu" :class="{visible: menuVisible}" v-if="menuVisible" v-cloak>
<a class="item" :href="run.link+'/jobs/'+jobIndex+'/logs'" target="_blank">
<a class="item" :href="run.link+'/jobs/'+jobIndex+'/logs'" target="_blank" v-if="currentJob.steps.length>0">
<i class="icon"><SvgIcon name="octicon-download"/></i>
{{ locale.downloadLogs }}
</a>
<a class="item disabled" href="" target="_blank" v-else>
<i class="icon"><SvgIcon name="octicon-download"/></i>
{{ locale.downloadLogs }}
</a>
Expand Down