Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix go get subpackage bug #2584

Merged
merged 2 commits into from
Sep 23, 2017
Merged

fix go get subpackage bug #2584

merged 2 commits into from
Sep 23, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 23, 2017

will fix #2577

@lunny lunny added the type/bug label Sep 23, 2017
@lunny lunny added this to the 1.3.0 milestone Sep 23, 2017
@codecov-io
Copy link

codecov-io commented Sep 23, 2017 •
edited
Loading

Codecov Report

Merging #2584 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2584   +/-   ##
=======================================
  Coverage   27.33%   27.33%           
=======================================
  Files          86       86           
  Lines       17137    17137           
=======================================
  Hits         4684     4684           
  Misses      11775    11775           
  Partials      678      678

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2db424c...9fcb2e8. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 23, 2017
@lafriks
Copy link
Member

lafriks commented Sep 23, 2017

LGTM

daviian
daviian suggested changes Sep 23, 2017
View reviewed changes
routers/repo/http.go Outdated
@@ -27,7 +27,7 @@ import (
)

func composeGoGetImport(owner, repo, sub string) string {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unused parameter sub

@lunny lunny force-pushed the lunny/fix_incorrect_meta_tags branch from 3738f30 to 9fcb2e8 Compare September 23, 2017 12:42
@lunny
Copy link
Member Author

lunny commented Sep 23, 2017

@daviian done.

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 23, 2017
@daviian
Copy link
Member

daviian commented Sep 23, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 23, 2017
@lafriks lafriks merged commit 2ef8b8b into go-gitea:master Sep 23, 2017
lunny added a commit to lunny/gitea that referenced this pull request Sep 23, 2017
@lunny
fix go get subpackage bug (go-gitea#2584)
d46d846 
* fix go get subpackage bug

* merge the duplicated funtions
@lunny lunny mentioned this pull request Sep 23, 2017
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Sep 23, 2017
@lunny lunny deleted the lunny/fix_incorrect_meta_tags branch September 23, 2017 13:41
lafriks pushed a commit that referenced this pull request Sep 23, 2017
@lunny @lafriks
fix go get subpackage bug (#2584) (#2589)
03ff768 
* fix go get subpackage bug

* merge the duplicated funtions
@sapk
Copy link
Member

sapk commented Oct 1, 2017

This is not working on try.gitea.io (bae9cbc) but at first glance don't know why since it should 😞
https://try.gitea.io/Howl/gorepo/test/test?go-get=1

<html>
	<head>
		<meta name="go-import" content="localhost/Howl/gorepo/test/test git https://try.gitea.io/Howl/gorepo.git">
		<meta name="go-source" content="localhost/Howl/gorepo/test/test _ https://try.gitea.io/Howl/gorepo/src/master{/dir} https://try.gitea.io/Howl/gorepo/src/master{/dir}/{file}#L{line}">
	</head>
	<body>
		go get localhost/Howl/gorepo/test/test
	</body>
</html>```

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daviian daviian daviian approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

go-get meta tags are incorrect, cause infinite recursion
6 participants
@lunny @codecov-io @lafriks @daviian @sapk @tboerger