Skip to content

Fix commits table regression #25710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 6, 2023
Merged

Fix commits table regression #25710

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
daa7ccc
fix commits table
denyskon Jul 5, 2023
f91a390
do not alter table display
denyskon Jul 5, 2023
0185baa
do not set white-space: nowrap for commit message
denyskon Jul 5, 2023
3246107
fix wrap of unbroken lines
silverwind Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/repo/commits_list.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="ui attached table segment commit-table">
<table class="ui very basic striped table unstackable" id="commits-table">
<table class="ui very basic striped table unstackable fixed" id="commits-table">
<thead>
<tr>
<th class="three wide">{{.locale.Tr "repo.commits.author"}}</th>
Expand Down
17 changes: 4 additions & 13 deletions web_src/css/repo.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1313,8 +1313,9 @@
padding: 5px 10px;
}

.repository #commits-table thead th:first-of-type {
padding-left: 15px;
.repository #commits-table {
display: block;
white-space: nowrap;
}

.repository #commits-table thead .sha {
Expand All @@ -1331,6 +1332,7 @@

.repository #commits-table td.message {
text-overflow: unset;
white-space: normal;
}

.repository #commits-table.ui.basic.striped.table tbody tr:nth-child(2n) {
Expand Down Expand Up @@ -3244,17 +3246,6 @@ tbody.commit-list {
.commit-table th.sha {
display: none !important;
}
.commit-table .commit-list span.message-wrapper {
max-width: none;
}
.commit-table .commit-list tr td:first-child,
.commit-table .commit-list tr td:last-child {
white-space: nowrap;
}
.commit-table .commit-list td.author {
display: block;
width: calc(100% + 0.5rem);
}
.commit-table .commit-list .copy-commit-sha {
display: none !important;
}
Expand Down