Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: Sync releases table with tags on push and for mirrors (#2459) #2554

Merged
merged 1 commit into from
Sep 20, 2017
Merged

Backport: Sync releases table with tags on push and for mirrors (#2459) #2554

merged 1 commit into from
Sep 20, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Sep 20, 2017

  • Sync releases table with tags on push and for mirrors

  • Code style fixes

  • Fix api to return only releases

  • Optimize release creation and update
    Minimize posibility of race conditions

  • Fix release lower tag name updating

  • handle tag reference update by addionally comparing commit id

@lafriks lafriks added this to the 1.2.0 milestone Sep 20, 2017
@lunny
Copy link
Member

lunny commented Sep 20, 2017

backport from #2459

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 20, 2017
@daviian
Copy link
Member

daviian commented Sep 20, 2017

LGTM

@daviian
Copy link
Member

daviian commented Sep 20, 2017

Make LG-TM work

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 20, 2017
@daviian
Copy link
Member

daviian commented Sep 20, 2017

@lafriks Tested and it does exactly the same as on master ;-)

@daviian
Copy link
Member

daviian commented Sep 20, 2017 •
edited
Loading

@lafriks Can you do a force push / rebase to restart drone build?

@lafriks
Copy link
Member Author

lafriks commented Sep 20, 2017 •
edited
Loading

I will after other PR is merged as I will need to resolve conflicts then EDIT: done

@lafriks
Sync releases table with tags on push and for mirrors (go-gitea#2459)
02ce2c4 
* Sync releases table with tags on push and for mirrors

* Code style fixes

* Fix api to return only releases

* Optimize release creation and update
Minimize posibility of race conditions

* Fix release lower tag name updating

* handle tag reference update by addionally comparing commit id
@sapk
Copy link
Member

sapk commented Sep 20, 2017

Trusted LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 20, 2017
@lafriks lafriks merged commit e232c49 into go-gitea:release/v1.2 Sep 20, 2017
@lafriks lafriks deleted the backport_tag_sync branch September 20, 2017 22:08
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lafriks @lunny @daviian @sapk @tboerger