Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: Fix lint, fmt and integration testing errors #2553

Merged
merged 3 commits into from
Sep 20, 2017
Merged

Backport: Fix lint, fmt and integration testing errors #2553

merged 3 commits into from
Sep 20, 2017

Conversation

ethantkoenig
Copy link
Member

Backport of #2547.

@ethantkoenig
Copy link
Member Author

😢

We require go version 1.7 or 1.8 to format code
make: *** [Makefile:60: required-gofmt-version] Error 1

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 20, 2017
@lunny lunny added this to the 1.2.0 milestone Sep 20, 2017
@lafriks lafriks mentioned this pull request Sep 20, 2017
Closed
@tboerger
Copy link
Member 

# docker run --rm webhippie/golang:edge go version
go version go1.9 linux/amd64

@lafriks
Copy link
Member

lafriks commented Sep 20, 2017

Depends on #2561

@sapk
Copy link
Member

sapk commented Sep 20, 2017

LGTM

1 similar comment
@daviian
Copy link
Member

daviian commented Sep 20, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 20, 2017
@lafriks
Copy link
Member

lafriks commented Sep 20, 2017 •
edited
Loading

@ethantkoenig git cherry-pick a1ed239bf277b0f17694e2e5685368d373e010c7 to your branch. I tried but had no rights to push to your repository :)

EDIT: need to use ssh to be able to push to your repo

@lafriks
Copy link
Member

lafriks commented Sep 20, 2017

Backport also Hotfix for integration testing (#2473)

@ethantkoenig ethantkoenig changed the title Fix lint errors Fix lint and fmt errors Sep 20, 2017
@ethantkoenig
Copy link
Member Author

ethantkoenig commented Sep 20, 2017 •
edited
Loading

@lafriks Rebased on release/v1.2, with fmt fixes

@tboerger @lafriks
Hotfix for integration testing (go-gitea#2473)
14e91e7 
* Hotfix for integration testing

* Comment sqlite tests because of database locking issues
@lafriks
Copy link
Member

lafriks commented Sep 20, 2017

@ethantkoenig I also added backport/cherry-pick for integration test fixes

@lafriks lafriks changed the title Fix lint and fmt errors Backport: Fix lint, fmt and integration testing errors Sep 20, 2017
@lafriks lafriks merged commit f014e42 into go-gitea:release/v1.2 Sep 20, 2017
@ethantkoenig ethantkoenig deleted the relv1.2 branch September 21, 2017 04:39
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ethantkoenig @tboerger @lafriks @sapk @daviian @lunny