Load reviewer for comments when dismissing a review (#24281) #24288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a comment dismisses a review, we need to load the reviewer to show whose review has been dismissed. Related to: https://github.com/go-gitea/gitea/blob/20b6ae0e5399cfc22c6a0989d8e520194e920bdd/templates/repo/issue/view_content/comments.tmpl#L765-L770 We don't need `.Review.Reviewer` for all comments, because "dismissing" doesn't happen often, or we would have already received error reports.
delvh
approved these changes
Apr 23, 2023
GiteaBot
added
the
lgtm/need 1
wxiaoguang
approved these changes
Apr 23, 2023
GiteaBot
added
lgtm/done
delvh
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #24281 by @wolfogre
If a comment dismisses a review, we need to load the reviewer to show whose review has been dismissed.
Related to:
gitea/templates/repo/issue/view_content/comments.tmpl
Lines 765 to 770 in 20b6ae0
Steps to reproduce the bug:
We doesn't need
.Review.Reviewerfor all comments, because "dismissing" doesn't happen often, or we would have already received error reports.