Skip to content

Fix unclear "Owner" concept #24233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2023
Merged

Fix unclear "Owner" concept #24233

merged 1 commit into from
Apr 20, 2023

Conversation

@wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Apr 20, 2023 •
edited
Loading

Related: #24232

Some user/org pages use Owner variable. It's an incorrect concept since year 2016: what is a user's owner?

Actually, new code is right: use ContextUser.

This PR cleans all legacy "Owner" variables.

Screenshots for related pages and test results

All pages are as before:

web/org/home.go

image

web/user/profile.go

image

web/user/setting/profile.go

image

@wxiaoguang wxiaoguang mentioned this pull request Apr 20, 2023
Merged
@silverwind silverwind added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Apr 20, 2023
@silverwind silverwind added this to the 1.20.0 milestone Apr 20, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 20, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 20, 2023
@6543 6543 merged commit 70fc47a into go-gitea:main Apr 20, 2023
@wxiaoguang wxiaoguang deleted the fix-var-owner branch April 21, 2023 00:55
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 21, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
a4c41bb 
* giteaofficial/main:
  Fix label color, fix divider in dropdown (go-gitea#24215)
  [skip ci] Updated translations via Crowdin
  Refactor web route (go-gitea#24080)
  Fix unclear "Owner" concept (go-gitea#24233)
  Introduce eslint-plugin-no-jquery/no-event-shorthand (go-gitea#24198)
  Use secondary pointing menu for tabs on user/organization home page (go-gitea#24162)
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 2, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@silverwind silverwind silverwind approved these changes

@6543 6543 6543 approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

1.20.0

Development

Successfully merging this pull request may close these issues.

4 participants

@wxiaoguang @silverwind @6543 @GiteaBot