Skip to content

Sync the class change of Edit Column Button to JS code #23400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 12, 2023
Merged

Sync the class change of Edit Column Button to JS code #23400

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
67224c3
fix
yp05327 Mar 10, 2023
6e223c5
add edit-column-button class
yp05327 Mar 10, 2023
e3eb17f
change the others
yp05327 Mar 10, 2023
cc69ae7
remove space
yp05327 Mar 10, 2023
bc95e4e
Merge branch 'main' into fix-cannot-change-project-column-color
techknowlogick Mar 11, 2023
a56aa84
Merge branch 'main' into fix-cannot-change-project-column-color
zeripath Mar 11, 2023
30877a5
Merge branch 'main' into fix-cannot-change-project-column-color
techknowlogick Mar 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/projects/view.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@

<div class="text right actions">
<div class="ui cancel button">{{$.locale.Tr "settings.cancel"}}</div>
<button data-url="{{$.Link}}/{{.ID}}" class="ui primary button">{{$.locale.Tr "repo.projects.column.edit"}}</button>
<button data-url="{{$.Link}}/{{.ID}}" class="ui primary button edit-column-button">{{$.locale.Tr "repo.projects.column.edit"}}</button>
</div>
</form>
</div>
Expand Down
10 changes: 3 additions & 7 deletions web_src/js/features/repo-projects.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,19 +95,15 @@ export function initRepoProject() {
$('.edit-project-board').each(function () {
const projectHeader = $(this).closest('.board-column-header');
const projectTitleLabel = projectHeader.find('.board-label');
const projectTitleInput = $(this).find(
'.content > .form > .field > .project-board-title',
);
const projectColorInput = $(this).find('.content > .form > .field #new_board_color');
const projectTitleInput = $(this).find('.project-board-title');
const projectColorInput = $(this).find('#new_board_color');
const boardColumn = $(this).closest('.board-column');

if (boardColumn.css('backgroundColor')) {
setLabelColor(projectHeader, rgbToHex(boardColumn.css('backgroundColor')));
}

$(this)
.find('.content > .form > .actions > .red')
.on('click', function (e) {
$(this).find('.edit-column-button').on('click', function (e) {
e.preventDefault();

$.ajax({
Expand Down