Skip to content

Scoped labels: set aria-disabled on muted Exclusive option for a11y #23306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2023
Merged

Scoped labels: set aria-disabled on muted Exclusive option for a11y #23306

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9295943
Scoped labels: set aria-disabled on muted Exclusive option for a11y
brechtvl Mar 4, 2023
44d0018
Merge branch 'main' into scoped-label-exclusive-a11y
lunny Mar 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions web_src/js/features/comp/LabelEdit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,15 @@ function updateExclusiveLabelEdit(form) {

if (isExclusiveScopeName(nameInput.val())) {
exclusiveField.removeClass('muted');
exclusiveField.removeAttr('aria-disabled');
if (exclusiveCheckbox.prop('checked') && exclusiveCheckbox.data('exclusive-warn')) {
exclusiveWarning.removeClass('gt-hidden');
} else {
exclusiveWarning.addClass('gt-hidden');
}
} else {
exclusiveField.addClass('muted');
exclusiveField.attr('aria-disabled', 'true');
exclusiveWarning.addClass('gt-hidden');
}
}
Expand Down