Skip to content

Add accessibility to the menu on the navbar #23059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 22, 2023
Merged

Add accessibility to the menu on the navbar #23059

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6e22dbd
try add accessibility to the meny
HesterG Feb 22, 2023
bb90c11
use button tag
HesterG Feb 22, 2023
8996d09
Merge branch 'main' into add-accessibility-to-menu
delvh Feb 22, 2023
05a9b09
Merge branch 'main' into add-accessibility-to-menu
delvh Feb 22, 2023
9f8fbb2
Merge branch 'main' into add-accessibility-to-menu
jolheiser Feb 22, 2023
b54e8bd
Merge branch 'main' into add-accessibility-to-menu
jolheiser Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/base/head_navbar.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
</span>
</a>
{{end}}
<div class="ui icon button mobile-only" id="navbar-expand-toggle">
<div class="ui icon button mobile-only" id="navbar-expand-toggle" tabindex="0" role="button">
{{svg "octicon-three-bars"}}
</div>
</div>
Expand Down