Only update needed columns when update user

[lunny]

Also fix #1882. After this merged, I will back ported to branch release/v1.1.

[sapk]

Can't we iterate over cols array and with a switch only do needed operation when matching col ?

Example : https://play.golang.org/p/4pRMeP89Re

[lunny]

Didn't get what you mean.

[sapk]

Maybe it is overkill

// UpdateUserCols update user according special columns
func UpdateUserCols(u *User, cols ...string) error {
	//Format only when needed
	for _, c := range cols {
		switch c {
		case "email":
			// Organization does not need email
			u.Email = strings.ToLower(u.Email)
			if !u.IsOrganization() {
				if len(u.AvatarEmail) == 0 {
					u.AvatarEmail = u.Email
				}
			}
		case "name":
			u.LowerName = strings.ToLower(u.Name)
		case "location":
			u.Location = base.TruncateString(u.Location, 255)
		case "website":
			u.Website = base.TruncateString(u.Website, 255)
		case "description":
			u.Description = base.TruncateString(u.Description, 255)
		}
	}
	if !u.IsOrganization() {
		if len(u.AvatarEmail) > 0 {
			u.Avatar = base.HashEmail(u.AvatarEmail)
		}
	}
	_, err := x.Id(u.ID).Cols(cols...).Update(u)
	return err
}

[ethantkoenig]

The updated_unix column won't be updated. I think we need to do something similar to #2204

[lunny]

done.

[ethantkoenig]

Adding a new function seems like overkill to me, is there a reason we can't just fix the updateUser(..) function to not write to u.Avatar (and require the caller of updateUser() to update u.Avatar if they actually need it)?

[sapk]

@ethantkoenig We could add a new func generateAvatar that is call before updateUser only when email is change or needed ?

[lunny]

@ethantkoenig I think updateUser is not corrected in many place where only need to update serval columns but update all the columns. So I added a new function updateUserCols to do that. And there are still some place where we should use updateUser to update all the columns.
We cannot finish the work only improve updateUser function, so I create the new one.
For fix of #1882, it's not the PR's main idea. #1882 's problem is when user login, the avatar will be updated, so the avatar changed. In fact, the only needed change column on login is last_login_time but it update all the columns. When I change to updateUserCols, the bug is also fixed.

[lunny]

@sapk that could be another PR.

[ethantkoenig]

LGTM

[lafriks]

LGTM

[lafriks]

Make LG-TM work