Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SHOW_USER_EMAIL also apply to profiles #2258

Merged
merged 1 commit into from
Aug 17, 2017
Merged

Make SHOW_USER_EMAIL also apply to profiles #2258

merged 1 commit into from
Aug 17, 2017

Conversation

michaelkuhn
Copy link
Contributor

The e-mail address is currently only hidden from the explore page.

@lunny lunny added the type/enhancement An improvement of existing functionality label Aug 4, 2017
@lunny lunny added this to the 1.x.x milestone Aug 4, 2017
@lafriks
Copy link
Member

lafriks commented Aug 5, 2017

Please add integration test for this

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 5, 2017
@michaelkuhn
Make SHOW_USER_EMAIL also apply to profiles
43dbc33 
The e-mail address is currently only hidden from the explore page.
@michaelkuhn
Copy link
Contributor Author

I have added an integration test. Please let me know if it okay like this, as I am pretty new to Go.

@strk
Copy link
Member

strk commented Aug 17, 2017

Could the test also test the other variables involved in the condition? Other thansuch that LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 17, 2017
@lunny lunny modified the milestones: 1.2.0, 1.x.x Aug 17, 2017
@lunny
Copy link
Member

lunny commented Aug 17, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 17, 2017
@lunny lunny merged commit 934dd41 into go-gitea:master Aug 17, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@michaelkuhn @lafriks @strk @lunny @tboerger