EnableUnit() -> UnitEnabled() #2242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You forgot to change the function name in templates. See https://github.com/go-gitea/gitea/search?utf8=✓&q=EnableUnit&type= |
bkcsoft
added
the
lgtm/need 2
ethantkoenig
force-pushed
the
rename/unit
branch
from
9ab294b
to
9d86559
Compare
lunny
added
the
type/refactoring
|
LGTM |
bkcsoft
added
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the
Repository.EnableUnit(..)andTeam.EnableUnit(..)methods (which check if a unit is enabled) toUnitEnabled(..). The original names seems misleading, sinceEnableUnit(..)sounds like a method that enables a unit, not one that checks if a unit is enabled.Calls the method in more places to remove boilerplate.