Add more test directory to exclude dir of air, remove watching templates from air include dir because gitea has internal mechanism (#22246) #22247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes from air include dir because gitea has internal mechanism (go-gitea#22246) Since go-gitea#20218 introduced internal watching template, template watching should be removed from `air`. This will prevent restart the whole server once the template files changed to speed up developing when using `make watch`. To ensure `make watch` will reuse template watching, this PR introduced a new ENV `GITEA_RUN_MODE` to make sure `make watch` will always run in a dev mode of Gitea so that template watching will open. This PR also added more exclude testdata directories.
lunny
added
the
topic/build
6543
approved these changes
Dec 29, 2022
GiteaBot
added
the
lgtm/need 1
KN4CK3R
approved these changes
Dec 29, 2022
GiteaBot
added
lgtm/done
6543
added
the
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #22246
Since #20218 introduced internal watching template, template watching should be removed from
air. This will prevent restart the whole server once the template files changed to speed up developing when usingmake watch.To ensure
make watchwill reuse template watching, this PR introduced a new ENVGITEA_RUN_MODEto make suremake watchwill always run in a dev mode of Gitea so that template watching will open.This PR also added more exclude testdata directories.