Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix container layer display overflow #22208

Merged
merged 4 commits into from
Dec 22, 2022
Merged

Fix container layer display overflow #22208

merged 4 commits into from
Dec 22, 2022

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Dec 22, 2022 •
edited
Loading

Before:
attels

After:
attels

@lafriks lafriks added type/bug topic/ui Change the appearance of the Gitea UI backport/v1.17 outdated/backport/v1.18 This PR should be backported to Gitea 1.18 labels Dec 22, 2022
@lafriks lafriks added this to the 1.19.0 milestone Dec 22, 2022
@silverwind
Copy link
Member

silverwind commented Dec 22, 2022 •
edited
Loading

Better to add a overflow-x-auto helper, but I think it should probably just wrap because horizontal scrolling is weird.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 22, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 22, 2022
@lafriks
Copy link
Member Author

lafriks commented Dec 22, 2022 •
edited
Loading

@silverwind changed to word break (updated also screenshots)

@silverwind
Copy link
Member

silverwind commented Dec 22, 2022 •
edited
Loading

Try with the existing word-break helper instead. It should be able to break everything.

@lafriks
Copy link
Member Author

lafriks commented Dec 22, 2022

@silverwind done

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 22, 2022
@lafriks lafriks added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 22, 2022
@lafriks lafriks merged commit 6037043 into go-gitea:main Dec 22, 2022
@lafriks lafriks deleted the fix/container-image-layers-overflow branch December 22, 2022 10:33
@lafriks lafriks removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 22, 2022
lafriks added a commit to lafriks-fork/gitea that referenced this pull request Dec 22, 2022
@lafriks
Fix container layer display overflow (go-gitea#22208)
cff5d8e 
Before:

![attels](https://user-images.githubusercontent.com/165205/209109653-6c690569-ddbe-4d8b-ab42-66b9a9c6a556.png)


After:

![attels](https://user-images.githubusercontent.com/165205/209110521-8aa8fc1c-21c8-4280-9b39-ab560b6d95f4.png)
@lafriks lafriks mentioned this pull request Dec 22, 2022
Merged
lafriks added a commit to lafriks-fork/gitea that referenced this pull request Dec 22, 2022
@lafriks
Fix container layer display overflow (go-gitea#22208)
43aba73 
Before:

![attels](https://user-images.githubusercontent.com/165205/209109653-6c690569-ddbe-4d8b-ab42-66b9a9c6a556.png)

After:

![attels](https://user-images.githubusercontent.com/165205/209110521-8aa8fc1c-21c8-4280-9b39-ab560b6d95f4.png)
@lafriks lafriks mentioned this pull request Dec 22, 2022
Merged
@lafriks lafriks added the backport/done All backports for this PR have been created label Dec 22, 2022
@KN4CK3R
Copy link
Member

KN4CK3R commented Dec 22, 2022

Is this the universal version of #21251?

@silverwind
Copy link
Member

The helper should be pretty universal, but tables may need special care as many CSS properties that work everywhere else do not work on tables.

lunny pushed a commit that referenced this pull request Dec 22, 2022
@lafriks
Fix container layer display overflow (#22208) (#22212)
7dcf9dd 
Backport #22208
KN4CK3R pushed a commit that referenced this pull request Dec 22, 2022
@lafriks
Fix container layer display overflow (#22208) (#22211)
2a5e7f8 
Backport #22208
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 23, 2022
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
7029e14 
* giteaoffical/main: (32 commits)
  Hide file borders on sticky diff box (go-gitea#22217)
  Test views of LFS files (go-gitea#22196)
  update docs latest to 1.17.4
  Frontport 1.17.4 changelog (go-gitea#22216)
  Remove test session cache to reduce possible concurrent problem (go-gitea#22199)
  Upgrade hugo to 0.82 (go-gitea#22209)
  Fix container layer display overflow (go-gitea#22208)
  Run hugo via `go run` and lock its version (go-gitea#22206)
  Update bleve and zapx to fix unaligned atomic (go-gitea#22031)
  Allow empty assignees on pull request edit (go-gitea#22150)
  Add Feed for Releases and Tags (go-gitea#21696)
  fix: update libcurl in docs pipeline (go-gitea#22203)
  Fixed colour transparency regex matching in project board sorting (go-gitea#22091) (go-gitea#22092)
  Mobile fix for Project view: Add delay to Sortable.js on mobile, to ensure scrolling is possible. (go-gitea#22152)
  Normalize NuGet package version on upload (go-gitea#22186)
  Attempt to fix TestExportUserGPGKeys (go-gitea#22159)
  Specify ID in `TestAPITeam` (go-gitea#22192)
  Repair LFS web rendering. (go-gitea#22195)
  Fix misc whitespace issues in install docs (go-gitea#22189)
  Update JS dependencies and eslint (go-gitea#22190)
  ...
@AbdulrhmnGhanem AbdulrhmnGhanem mentioned this pull request Dec 30, 2022
Merged
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@silverwind silverwind silverwind approved these changes

@zeripath zeripath Awaiting requested review from zeripath

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.18 This PR should be backported to Gitea 1.18 topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lafriks @silverwind @KN4CK3R @zeripath @delvh @GiteaBot