Use sqlite3 database as default for Docker image #2182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
app.ini
template file in the Docker image is currently usingmysql
as default database engine. However, it's not practical as default. Because,gitea
, such as:mysql
instance inside docker, which has to be named asmysql
,gitea
,mysql
'sroot
user has to be empty.mysql
as the database, are more likely provide their ownapp.ini
file, to specify the server address, mysql IP/name, reasonable user & password, etc.So, my suggestion is that replacing the
mysql
withsqlite3
as default. So, anyone who just want to simply run thegitea
image to get an idea, can just run the image without providing a customizedapp.ini
file or preparing a MySQL server.Signed-off-by: Tao Wang [email protected]