Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sqlite3 database as default for Docker image #2182

Merged
merged 1 commit into from
Jul 26, 2017

Conversation

twang2218
Copy link
Contributor

The app.ini template file in the Docker image is currently using mysql as default database engine. However, it's not practical as default. Because,

  1. It require more setup to run gitea, such as:
    • run a mysql instance inside docker, which has to be named as mysql,
    • prepare a database called gitea,
    • and the password of the mysql's root user has to be empty.
  2. People, who are going to use mysql as the database, are more likely provide their own app.ini file, to specify the server address, mysql IP/name, reasonable user & password, etc.

So, my suggestion is that replacing the mysql with sqlite3 as default. So, anyone who just want to simply run the gitea image to get an idea, can just run the image without providing a customized app.ini file or preparing a MySQL server.

Signed-off-by: Tao Wang [email protected]

@lafriks lafriks added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Jul 19, 2017
@lunny lunny added this to the 1.3.0 milestone Jul 20, 2017
@sapk
Copy link
Member

sapk commented Jul 24, 2017

LGTM

@sapk
Copy link
Member

sapk commented Jul 24, 2017

This will display by default sqlite3 on /install page if I am not mistaken.

@twang2218
Copy link
Contributor Author

Yes, the default database type is SQLite3 on the install page:

screenshot 2017-07-24 19 28 44

User still need to go through the install process to get a running server though. My another PR #2201 goes one step further, with environment variable, user can run the gitea docker image with some customization abilities, but without necessary go through the install process, and without the necessary given the app.ini file.

@lunny
Copy link
Member

lunny commented Jul 24, 2017

LGTM

@lafriks lafriks added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Jul 24, 2017
@lafriks lafriks modified the milestones: 1.2.0, 1.3.0 Jul 24, 2017
@lunny
Copy link
Member

lunny commented Jul 26, 2017

make L-G-T-M work

@lunny lunny merged commit 41cc110 into go-gitea:master Jul 26, 2017
@twang2218 twang2218 deleted the change-default-database-to-sqlite3 branch July 31, 2017 01:10
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants