Skip to content

Ignore port for loopback redirect URIs (#21293) #21373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2022
Merged

Ignore port for loopback redirect URIs (#21293) #21373

merged 1 commit into from
Oct 8, 2022
+33 −0

Conversation

@hickford
Copy link
Contributor

@hickford hickford commented Oct 7, 2022

@hickford hickford changed the base branch from main to release/v1.17 October 7, 2022 20:04
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 7, 2022
@zeripath zeripath added this to the 1.17.3 milestone Oct 7, 2022
@zeripath
Copy link
Contributor

zeripath commented Oct 7, 2022

Hmm... did you initially open this against main?

Could you push another commit to see if we can make CI realise it should be checking against 1.17 instead?

@hickford
Copy link
Contributor Author

hickford commented Oct 7, 2022

Hmm... did you initially open this against main?

Yep. Repushed.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 7, 2022
@wxiaoguang wxiaoguang merged commit 672d54f into go-gitea:release/v1.17 Oct 8, 2022
tyroneyeh added a commit to tyroneyeh/gitea that referenced this pull request Oct 24, 2022
@tyroneyeh
Ignore port for OAuth2 loopback redirect URIs (go-gitea#21293) (go-gi…
98927cd 
…tea#21373)

Backport go-gitea#21293

Following https://datatracker.ietf.org/doc/html/rfc8252#section-7.3

Fixes go-gitea#21285
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@6543 6543 6543 approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.17.3

Development

Successfully merging this pull request may close these issues.

OAuth module missing special handling for loopback redirect URI

5 participants

@hickford @zeripath @6543 @wxiaoguang @GiteaBot