Skip to content

Fix the quick-submit for pending review comment #20992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 2, 2022
Merged

Fix the quick-submit for pending review comment #20992

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b8e5a1c
Fix the quick-submit for pending review comment
wxiaoguang Aug 29, 2022
f2ffbb1
Merge branch 'main' into fix-quick-submit-pending-review
lunny Sep 2, 2022
abfc2b4
Merge branch 'main' into fix-quick-submit-pending-review
lunny Sep 2, 2022
09c47db
Merge branch 'main' into fix-quick-submit-pending-review
techknowlogick Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions templates/repo/diff/comment_form.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
<input type="hidden" name="reply" value="{{$.reply}}">
{{else}}
{{if $.root.CurrentReview}}
{{/* if there is only one "Add comment" button, the quick-submit should submit the form with is_review=true even if the "Add comment" button is not really clicked */}}
<input type="hidden" name="is_review" value="true">
<button name="is_review" value="true" type="submit"
class="ui submit green tiny button btn-add-comment">{{$.root.locale.Tr "repo.diff.comment.add_review_comment"}}</button>
{{else}}
Expand Down