-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix git hooks update to receive required arguments #2095
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafriks
force-pushed
the
fix/git_server_hooks
branch
from
July 1, 2017 21:43
5ffb26a
to
a8be8e4
Compare
lafriks
force-pushed
the
fix/git_server_hooks
branch
from
July 1, 2017 21:58
a8be8e4
to
fefd707
Compare
7 tasks
* Changed migration calling so that migrations can use models package
lafriks
force-pushed
the
fix/git_server_hooks
branch
from
July 1, 2017 22:07
fefd707
to
e9fa637
Compare
lafriks
changed the title
Fix git hooks update to receive required arguments.
Fix git hooks update to receive required arguments
Jul 1, 2017
@lafriks any chance to integrate your test codes on this PR? |
tboerger
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Jul 2, 2017
@lunny unless the test runs |
Oh. This clone test PR #1682 need go1.8 |
It's not easy to test this as this need clone and later push and parsing push output to check if this |
LGTM |
tboerger
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Jul 2, 2017
LGTM |
tboerger
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Jul 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2090