Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't ignore gravatar error #2083

Merged
merged 3 commits into from
Jun 30, 2017
Merged

Don't ignore gravatar error #2083

merged 3 commits into from
Jun 30, 2017

Conversation

ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented Jun 29, 2017 •
edited
Loading

Related to (but does may not fix) #2073.

@lunny lunny added the type/bug label Jun 29, 2017
@lunny lunny added this to the 1.2.0 milestone Jun 29, 2017
@lunny
Copy link
Member

lunny commented Jun 29, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 29, 2017
@cez81
Copy link
Contributor

cez81 commented Jun 29, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 29, 2017
@lafriks
Copy link
Member

lafriks commented Jun 29, 2017

I think on error it should return default avatar url

@cez81
Copy link
Contributor

cez81 commented Jun 29, 2017

Hmm, guess you have a point there

@ethantkoenig
Copy link
Member Author

@lafriks Good suggestion, updated

@andreynering andreynering merged commit 935b40f into go-gitea:master Jun 30, 2017
@ethantkoenig ethantkoenig deleted the check_err/org_avatar branch June 30, 2017 20:08
@lunny lunny mentioned this pull request Jul 11, 2017
Closed
7 tasks
@ethantkoenig ethantkoenig mentioned this pull request Jul 11, 2017
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Jul 11, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ethantkoenig @lunny @cez81 @lafriks @tboerger @andreynering