Skip to content

Fix package permission checks for organizations #20517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2022
Merged

Fix package permission checks for organizations #20517

merged 1 commit into from
Jul 28, 2022

Conversation

@KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Jul 28, 2022

fixes #19986

Is there already a helper method like GetOrgUserMaxAuthorizeLevel which does this?

@KN4CK3R KN4CK3R changed the title Extended permission checks. Fix package permission checks for organizations Jul 28, 2022
@KN4CK3R KN4CK3R added this to the 1.18.0 milestone Jul 28, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 28, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 28, 2022
@lunny lunny merged commit a846bfe into go-gitea:main Jul 28, 2022
@KN4CK3R KN4CK3R deleted the fix-19986 branch July 28, 2022 13:07
KN4CK3R added a commit to KN4CK3R/gitea that referenced this pull request Jul 28, 2022
@KN4CK3R
Extended permission checks. (go-gitea#20517)
9d046d9
@KN4CK3R KN4CK3R mentioned this pull request Jul 28, 2022
Merged
@KN4CK3R
Copy link
Member Author

KN4CK3R commented Jul 28, 2022

Backport in #20520

wxiaoguang pushed a commit that referenced this pull request Jul 28, 2022
@KN4CK3R
Fix package permission checks for organizations (#20517) (#20520)
a9a440e
@6543 6543 added the backport/done All backports for this PR have been created label Jul 28, 2022
@KN4CK3R KN4CK3R mentioned this pull request Aug 8, 2022
Closed
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
@KN4CK3R
Extended permission checks. (go-gitea#20517)
5c99508
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/packages type/bug

Projects

None yet

Milestone

1.18.0

Development

Successfully merging this pull request may close these issues.

Packages Write permission only works when ALL other permissions are set to Write

6 participants

@KN4CK3R @wxiaoguang @delvh @lunny @GiteaBot @6543