Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let not-logged-in users view releases #1999

Merged
merged 1 commit into from
Jun 18, 2017
Merged

Let not-logged-in users view releases #1999

merged 1 commit into from
Jun 18, 2017

Conversation

ethantkoenig
Copy link
Member

Allow non-logged-in users, and non-writers, to view releases of public repos.

@ethantkoenig ethantkoenig changed the title Not logged-in users can view releases Let logged-in users view releases Jun 17, 2017
@ethantkoenig ethantkoenig changed the title Let logged-in users view releases Let not-logged-in users view releases Jun 17, 2017
@ethantkoenig ethantkoenig mentioned this pull request Jun 17, 2017
Closed
@ethantkoenig
Copy link
Member Author

make test-sqlite keeps failing in CI 😞

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 18, 2017
@lunny lunny added this to the 1.2.0 milestone Jun 18, 2017
@lunny lunny added the type/enhancement An improvement of existing functionality label Jun 18, 2017
@lunny
Copy link
Member

lunny commented Jun 18, 2017

@ethantkoenig restarted and PASS. LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 18, 2017
@sapk
Copy link
Member

sapk commented Jun 18, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 18, 2017
@lunny lunny merged commit 4df1a24 into go-gitea:master Jun 18, 2017
@ethantkoenig ethantkoenig deleted the fix/view_releases branch June 18, 2017 13:02
@ethantkoenig ethantkoenig mentioned this pull request Jul 5, 2017
Closed
1 task
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ethantkoenig @lunny @sapk @tboerger