Skip to content

Fix signal loop in graceful manager #19943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wxiaoguang merged 3 commits into from
Jun 12, 2022
Merged

Fix signal loop in graceful manager #19943

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a971e6a
Fix signal loop
wxiaoguang Jun 11, 2022
b2861e2
Update manager_unix.go
wxiaoguang Jun 12, 2022
ffec88a
Merge branch 'main' into fix-signal-loop
lunny Jun 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions modules/graceful/manager_unix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ func (g *Manager) handleSignals(ctx context.Context) {
)

pid := syscall.Getpid()
loop:
for {
select {
case sig := <-signalChannel:
Expand Down Expand Up @@ -157,6 +158,7 @@ func (g *Manager) handleSignals(ctx context.Context) {
case <-ctx.Done():
log.Warn("PID: %d. Background context for manager closed - %v - Shutting down...", pid, ctx.Err())
g.DoGracefulShutdown()
break loop
}
}
}
Expand Down