Merged
Conversation
The recommended way is to use the name of the organisation followed by "logo". however, since this is my first contribution, I am not entirely sure, whether this is the best approach here. The organisation is different from the organisation you can create as part of the application. Instead, it is more related to the site hosting the instance. Plus, I don't know how to best handle it when the logo image is swapped out. Therefore, I use plain "Logo" and hope that the person visiting the site has enough context. Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
jolheiser
approved these changes
Jun 4, 2022
Member
jolheiser
left a comment
jolheiser
left a comment
There was a problem hiding this comment.
I think this looks good. Since the logo can be customized per-instance, I think "logo" makes generic sense.
Thanks!
GiteaBot
added
the
lgtm/need 1
Gusted
approved these changes
Jun 5, 2022
GiteaBot
added
lgtm/done
delvh
approved these changes
Jun 5, 2022
Codecov Report
@@ Coverage Diff @@
## main #19892 +/- ##
=======================================
Coverage ? 47.32%
=======================================
Files ? 959
Lines ? 133652
Branches ? 0
=======================================
Hits ? 63245
Misses ? 62707
Partials ? 7700 Continue to review full report at Codecov.
|
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 5, 2022
* giteaofficial/main: Add alt text to logo (go-gitea#19892) Limit max-height of CodeMirror editors for issue comment and wiki (go-gitea#18271) Implement http signatures support for the API (go-gitea#17565) Increment tests time out from 40m to 50m because sometimes the machine is slow (go-gitea#19887) fix(CI/CD): correct CI variable. (go-gitea#19886) Fix typo (go-gitea#19889) Fixing wrong paging when filtering on the issue dashboard (go-gitea#19801) Move `/info` outside authorization (go-gitea#19888) Fix order by parameter (go-gitea#19849) Exclude Archived repos from Dashboard Milestones (go-gitea#19882) use exact search instead of fuzzy search for branch filter dropdown (go-gitea#19885)
Merged
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
The recommended way is to use the name of the organisation followed by "logo". however, since this is my first contribution, I am not entirely sure, whether this is the best approach here. The organisation is different from the organisation you can create as part of the application. Instead, it is more related to the site hosting the instance. Plus, I don't know how to best handle it when the logo image is swapped out. Therefore, I use plain "Logo" and hope that the person visiting the site has enough context. Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #19891
The recommended way
is to use the name of the organisation followed by " logo".
However, since this is my first contribution, I am not entirely sure,
whether this is the best approach here.
The organisation is different from the organisation you can create as
part of the application. Instead, it is more related to the site
hosting the instance. Plus, I don't know how to best handle it when
the logo image is swapped out. Therefore, I use plain "Logo" and hope
that the person visiting the site has enough context.
According to CONTRIBUTING.md
the only translation file to edit as part of the code base is
en-US.ini.I noticed several sections there, but I assume, base stuff go into the top.
A lack of comments made me unsure, whether I guessed correctly.
This PR adds a new translation key (
logo) and therefore I added a newline to the ini file.
I ran
make fmtandmake lintlocally and found no errors or changes.Do we have tests for the markup? Where would I need to update one?
I only saw tests for
.gofiles (with a few for js). Rebuilding Gitea made thealt attribute appear with the English text in my local instance.
Signed-off-by: André Jaenisch andre.jaenisch@posteo.de