Fix GPG email checking to be case insensitive #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapk
reviewed
Jun 16, 2017
models/gpg_key.go
Outdated
| @@ -213,7 +213,7 @@ func parseGPGKey(ownerID int64, e *openpgp.Entity) (*GPGKey, error) { | |||
| for _, ident := range e.Identities { | |||
|
|
|||
| for _, e := range userEmails { | |||
| if e.Email == ident.UserId.Email && e.IsActivated { | |||
| if e.Email == strings.ToLower(strings.TrimSpace(ident.UserId.Email)) && e.IsActivated { | |||
There was a problem hiding this comment.
For little performance gain maybe cache strings.ToLower(strings.TrimSpace()) result in a tmp variable and not do it at each userEmails.
|
A little performance remark but otherwise LGTM. |
tboerger
added
the
lgtm/need 1
|
Fixed suggested changes and added unit test |
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1986