Fix order by #19821
Closed
Fix order by #19821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
approved these changes
May 28, 2022
GiteaBot
added
the
lgtm/need 1
Gusted
approved these changes
May 28, 2022
GiteaBot
added
lgtm/done
lunny
added
the
skip-changelog
|
Ugh this appears to have broken many things. I'm concerned that the requirement to use .SQL(...) and the weird dialect dance makes this a bit complex and certainly error prone. I think that we need to think again about the xorm interface - certainly the session.OrderBy(...) function needs to be changed to take interface{} pairs eg. from: func (session *Session) OrderBy(order string) *Session { ... }to: func (session *Session) OrderBy(order interface{}, args ...interface{}) *Session { ... }Then we need to think a bit more about how builders could pass down the ordering - but I suspect that keeping these separate from the condition would still be right. |
zeripath
added a commit
that referenced
this pull request
Jun 4, 2022
Upgrade builder to v0.3.11 Upgrade xorm to v1.3.1 and fixed some hidden bugs. Replace #19821 Replace #19834 Included #19850 Co-authored-by: zeripath <[email protected]>
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
Upgrade builder to v0.3.11 Upgrade xorm to v1.3.1 and fixed some hidden bugs. Replace go-gitea#19821 Replace go-gitea#19834 Included go-gitea#19850 Co-authored-by: zeripath <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.