Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make WIP prefixes case insensitive, e.g. allow Draft as a WIP prefix (#19780) #19811

Merged
merged 1 commit into from
May 26, 2022
Merged

Make WIP prefixes case insensitive, e.g. allow Draft as a WIP prefix (#19780) #19811

merged 1 commit into from
May 26, 2022

Commits on May 26, 2022

  1. Make WIP prefixes case insensitive, e.g. allow Draft as a WIP prefix ( 

    go-gitea#19780)

Backport go-gitea#19780

The issue was that only the actual title was converted to uppercase, but
not the prefix as specified in `WORK_IN_PROGRESS_PREFIXES`. As a result,
the following did not work:

    WORK_IN_PROGRESS_PREFIXES=Draft:,[Draft],WIP:,[WIP]

One possible workaround was:

    WORK_IN_PROGRESS_PREFIXES=DRAFT:,[DRAFT],WIP:,[WIP]

Then indeed one could use `Draft` (as well as `DRAFT`) in the title.
However, the link `Start the title with DRAFT: to prevent the pull request
from being merged accidentally.` showed the suggestion in uppercase; so
it is not possible to show it as `Draft`. This PR fixes it, and allows
to use `Draft` in `WORK_IN_PROGRESS_PREFIXES`.

Fixes go-gitea#19779.

Co-authored-by: zeripath <[email protected]>
    @certik @zeripath
    certik and zeripath committed May 26, 2022
    Configuration menu
    Copy the full SHA
    995d12a View commit details
    Browse the repository at this point in the history