Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pull-create integration test #1972

Merged
merged 1 commit into from
Jun 15, 2017
Merged

Add pull-create integration test #1972

merged 1 commit into from
Jun 15, 2017

Conversation

typeless
Copy link
Contributor

No description provided.

@typeless typeless force-pushed the add-integration-test-for-pull-create branch from eb217aa to 1c10ac6 Compare June 15, 2017 06:13
@lunny lunny added this to the 1.2.0 milestone Jun 15, 2017
@lunny
Copy link
Member

lunny commented Jun 15, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 15, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 15, 2017
@appleboy appleboy merged commit 033aaf4 into go-gitea:master Jun 15, 2017
tsl0922
tsl0922 reviewed Jun 15, 2017
View reviewed changes
integrations/pull_create_test.go
resp := session.MakeRequest(t, req)
assert.EqualValues(t, http.StatusOK, resp.HeaderCode)

// Click the little green button to craete a pull
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/craete/create

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@typeless really.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsl0922 Please make new PR to fix typo

@lunny lunny mentioned this pull request Jun 15, 2017
Merged
@tsl0922 tsl0922 mentioned this pull request Jun 15, 2017
Merged
@typeless typeless deleted the add-integration-test-for-pull-create branch April 3, 2019 05:00
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

@lunny lunny lunny left review comments

@tsl0922 tsl0922 tsl0922 left review comments

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@typeless @lunny @appleboy @tsl0922 @tboerger