Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't select join table's columns #19660

Merged
merged 2 commits into from
May 9, 2022
Merged

Conversation

lunny
Copy link
Member

@lunny lunny commented May 9, 2022

Replace #19632 because of #19632 (comment)

@lunny lunny added performance/memory Performance issues affecting memory use skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels May 9, 2022
@lunny lunny added this to the 1.17.0 milestone May 9, 2022
@lunny lunny changed the title Don't select join table Don't select join table's columns May 9, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 9, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 9, 2022
@lunny lunny merged commit e435283 into go-gitea:main May 9, 2022
@lunny lunny deleted the lunny/avoid_select branch May 9, 2022 15:19
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 10, 2022
* giteaofficial/main:
  Use better message for consistency check (go-gitea#19672)
  Fix new release from tags list UI (go-gitea#19670)
  Update go deps (go-gitea#19665)
  [doctor] Add check/fix for bogus action rows (go-gitea#19656)
  [skip ci] Updated translations via Crowdin
  Add tooltip to pending PR comments (go-gitea#19662)
  Add Webfinger endpoint (go-gitea#19462)
  Update documentation to disable duration settings with -1 instead of 0 (go-gitea#19647)
  Set the LastModified header for raw files (go-gitea#18356)
  Don't select join table's columns (go-gitea#19660)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
* Don't select join table

* Add comment
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. performance/memory Performance issues affecting memory use skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants