Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Reference" section to Issue view sidebar #19609

Merged
merged 7 commits into from
May 5, 2022
Merged

Add "Reference" section to Issue view sidebar #19609

merged 7 commits into from
May 5, 2022

Conversation

neonn
Copy link
Contributor

@neonn neonn commented May 4, 2022

Add a "References..." item to the sidebar when viewing an issue in a repository.

More detail can be found in #19608 , with examples of existing functionality.

Here is an example (when the project has been built):

Showing the panel differences with an image. A new section "References: ..." has been added.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 4, 2022
Gusted
Gusted approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@Gusted Gusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your first contribution!

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 4, 2022
wxiaoguang
wxiaoguang reviewed May 5, 2022
View reviewed changes
models/issue.go Outdated Show resolved Hide resolved
@wxiaoguang wxiaoguang added this to the 1.17.0 milestone May 5, 2022
@wxiaoguang wxiaoguang added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels May 5, 2022
@wxiaoguang wxiaoguang linked an issue May 5, 2022 that may be closed by this pull request
Add "Reference: " copy-pastable reference when viewing an issue #19608
Closed
@silverwind
Copy link
Member

silverwind commented May 5, 2022 •
edited
Loading

Can these big red buttons be de-emphasized, maybe just regular uncolored buttons?

Nevermind, not part of this PR.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 5, 2022
wxiaoguang
wxiaoguang requested changes May 5, 2022
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally L-G-T-M

I would suggest to remove the ReferenceLink (I can take the work if no objection).

(just mark it as requested changes to prevent to be merged too soon.)

wxiaoguang
wxiaoguang approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Let's wait for the CI pass, then get it merged. 🎉

@6543
Copy link
Member

6543 commented May 5, 2022

.

@6543 6543 merged commit 0483ee8 into go-gitea:main May 5, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 6, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
c756727 
* giteaofficial/main:
  Simplify `IsVendor` (go-gitea#19626)
  Prevent NPE when checking repo units if the user is nil (go-gitea#19625)
  Skip duplicated layers. (go-gitea#19624)
  Add "Reference" section to Issue view sidebar (go-gitea#19609)
  GetFeeds must always discard actions with dangling repo_id (go-gitea#19598)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@neonn @AbdulrhmnGhanem
Add "Reference" section to Issue view sidebar (go-gitea#19609)
1e357e7 
* Add "Reference" section to Issue view sidebar

* Removed unneeded tailored CSS, added Fomantic UI classes

* Removed tailored CSS in favour of HTML-only approach

Kindly provided by @Gusted

* Added i18 translation key for reference link string

* Corrected spelling of "References:" to "Reference:" for reference link text

* Removed `Issue.ReferenceLink` in favour of a local template variable
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@Gusted Gusted Gusted approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

Add "Reference: " copy-pastable reference when viewing an issue
7 participants
@neonn @silverwind @6543 @wxiaoguang @Gusted @delvh @GiteaBot