Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent intermittent race in attribute reader close (#19537) #19539

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Prevent intermittent race in attribute reader close (#19537) #19539

merged 1 commit into from
Apr 28, 2022

Commits on Apr 28, 2022

  1. Prevent intermittent race in attribute reader close (go-gitea#19537) 

    Backport go-gitea#19537

There is a potential rare race possible whereby the c.running channel could
be closed twice. Looking at the code I do not see a need for this c.running
channel and therefore I think we can remove this. (I think the c.running
might have been some attempt to prevent a hang but the use of os.Pipes should
prevent that.)

Signed-off-by: Andrew Thornton <[email protected]>
    @zeripath
    zeripath committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    be95ba5 View commit details
    Browse the repository at this point in the history