Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When dumping trim the standard suffices instead of a random suffix (#19440) #19447

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented Apr 20, 2022

Backport #19440

  • When dumping trim the standard suffices instead of a random suffix

Instead of using the path.Ext() to trim the last "extension" suffix, just iterate
through the supported suffices and trim those.

Fix #19424

  • fix enum with to have correct supported types only

Co-authored-by: 6543 [email protected]
Signed-off-by: Andrew Thornton [email protected]

…o-gitea#19440)

* When dumping trim the standard suffices instead of a random suffix

Instead of using the `path.Ext()` to trim the last "extension" suffix, just iterate
through the supported suffices and trim those.

Fix go-gitea#19424

Signed-off-by: Andrew Thornton <[email protected]>

* fix enum with to have correct supported types only

Co-authored-by: 6543 <[email protected]>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 20, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 20, 2022
@zeripath zeripath merged commit c5fe0a0 into go-gitea:release/v1.16 Apr 20, 2022
@zeripath zeripath deleted the backport_19440 branch April 20, 2022 22:26
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants