Switch to keybase go-crypto (for some elliptic curve key) + test #1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Though I'd prefer go-crypto/openpgp to be merged into stdlib 😉 |
tboerger
added
the
lgtm/need 1
ethantkoenig
suggested changes
Jun 12, 2017
models/gpg_key_test.go
Outdated
| -----END PGP PUBLIC KEY BLOCK-----` | ||
|
|
||
| key, err := checkArmoredGPGKeyString(testGPGArmor) | ||
| assert.Nil(t, err, "Could not parse a valid GPG armored key", key) |
There was a problem hiding this comment.
For checking errors, you should use assert.NoError(..)
There was a problem hiding this comment.
done and update all test in this file to use .Error .NotError
and add a little more context to failing test description
ethantkoenig
approved these changes
Jun 13, 2017
and assert.Error in place of .Nil/.NotNil
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1898 by using keybase/go-crypto in place of golang.org/x/crypto.
In folder openpgp, keybase/go-crypto is not that far away of golang.org/x/crypto and implement more key type.