Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache ctx.User in retrieveFeeds #1902

Merged
merged 1 commit into from
Jun 8, 2017
Merged

Cache ctx.User in retrieveFeeds #1902

merged 1 commit into from
Jun 8, 2017

Conversation

ethantkoenig
Copy link
Member

Add the already-loaded ctx.User to userCache

@andreynering andreynering added the type/enhancement An improvement of existing functionality label Jun 7, 2017
@andreynering andreynering added this to the 1.2.0 milestone Jun 7, 2017
@andreynering
Copy link
Contributor

Trusted LGTM

(I hope someday Xorm will support preloading, so we don't need to query each user separetely).

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 7, 2017
@lunny
Copy link
Member

lunny commented Jun 8, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 8, 2017
@lunny lunny merged commit 9ddc35e into go-gitea:master Jun 8, 2017
@ethantkoenig ethantkoenig deleted the cache_ctx_user branch June 8, 2017 14:22
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ethantkoenig @andreynering @lunny @tboerger